Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridded Coverage Extension 16-bit PNG - Signed / Unsigned contradiction? #551

Closed
jerstlouis opened this issue Oct 30, 2020 · 4 comments
Closed
Labels
TGCE Tiled Gridded Coverage Extension

Comments

@jerstlouis
Copy link
Member

In section 6.2. Storage formats and grid cell values ( http://docs.opengeospatial.org/is/17-066r1/17-066r1.html#_storage_formats_and_grid_cell_values ) it says:

using PNG (16-bit, signed integer)

Requirement 13 says:

the data SHALL be 16-bit unsigned integer (single channel - "greyscale").

As far as I understand PNG only supports unsigned integers. From https://en.wikipedia.org/wiki/Portable_Network_Graphics :

The permitted formats encode each number as an unsigned integer value using a fixed number of bits

It seems a proper fix would be to keep the requirement as-is but fix 6.2, but what are implementations currently doing?

Am I missing something?

@jyutzler jyutzler added the TGCE Tiled Gridded Coverage Extension label Nov 17, 2020
@jyutzler
Copy link
Contributor

We concur that a change is needed. We just need a pull request. Assigning to @ryanfranz.

@ryanfranz
Copy link

ryanfranz commented Jan 20, 2021

Pull request from https://github.com/ryanfranz/geopackage-tiled-gridded-coverage created.
This can be added to a corrigendum

@ryanfranz
Copy link

@jyutzler Changes have been merged, this can be closed

@jyutzler jyutzler mentioned this issue Feb 2, 2021
@jyutzler
Copy link
Contributor

jyutzler commented Feb 2, 2021

Closed via #575

@jyutzler jyutzler closed this as completed Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TGCE Tiled Gridded Coverage Extension
Projects
None yet
Development

No branches or pull requests

3 participants