Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide synonyms / stopwords in “root nodes” page #173

Closed
Tracked by #167
alexgarel opened this issue Jan 11, 2023 · 6 comments
Closed
Tracked by #167

hide synonyms / stopwords in “root nodes” page #173

alexgarel opened this issue Jan 11, 2023 · 6 comments
Assignees

Comments

@alexgarel
Copy link
Member

alexgarel commented Jan 11, 2023

We currently display synonyms and stopwords in "root nodes" page.

We shouldn't:

  1. because change in synonyms and stopwords are rare, and must be done by advanced users (they have a lot of implications
  2. we do not support editing them (and it's not a priority). If we support editing, in the future, they would have their own page.

So this issue is about not listing them in "root nodes" page.

@Jagrutiti
Copy link
Member

Does this issue some backend work too? Or is just FE?

@diivi
Copy link
Member

diivi commented Jan 20, 2023

Alex mentioned this in out last meeting, it is backend only.

@Jagrutiti
Copy link
Member

Alex mentioned this in out last meeting, it is backend only.

It is assigned to you so I was confused.

@Jagrutiti
Copy link
Member

Jagrutiti commented Jan 20, 2023

Hey @alexgarel

Here, do I have to filter get_all_root_nodes() function in entries.py?

I came to the conclusion because the root node API calls that function.

Also for query, I should refer to Neo4J syntax?

@diivi
Copy link
Member

diivi commented Jan 20, 2023

@Jagrutiti I have opened a PR for this issue as it was unassigned - #187

@Jagrutiti
Copy link
Member

@Jagrutiti I have opened a PR for this issue as it was unassigned - #187

My bad. Since you were working on the FE part I made the wrong assumption. I just saw your commits.

@diivi diivi closed this as completed Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants