Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest France web api to respect setup dependencies #79

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

sandcha
Copy link
Contributor

@sandcha sandcha commented Feb 19, 2019

Delete upgrade eager install for latest api

Before:
This requirements.txt with this --upgrade option at installation upgraded Core version even when it was incompatible with France latest merged version.

@bonjourmauko
Copy link
Member

Hello @sandcha, thanks !

  • Could you explicit also the consequences ? (after)
  • Do we have any trace of why were we using eager in the first place?

@Morendil
Copy link
Contributor

Morendil commented Feb 19, 2019

@maukoquiroga I suspect the root cause is that pip doesn't have a clear story about how it resolves dependencies, see e.g. this issue elaborating on this classic. See also this comment shedding light on what would otherwise be a puzzling failure on openfisca-senegal.

My best guess is that we tried --upgrade but found it was not eager enough, now we've tried --upgrade eager and that's over-eager. No Goldilocks solution seems to exist in pip. The alternatives (we've previously mentioned Pipenv, zazo) seem to lack maturity.

So, it's possible that the consequences include "the next time we deploy, one of the dependencies stays behind instead of advancing as we wish". This is one reason we might want to consider deploying to a PaaS supporting an "immutable infrastructure" approach, installing from a clean slate each time.

@sandcha sandcha merged commit a7753d4 into master Feb 20, 2019
@sandcha sandcha deleted the fix-latest branch February 20, 2019 00:13
@fpagnoux
Copy link
Member

Arg, this PR removed the --upgrade, which means that we never upgrade anything... The /latest version of the API is now 8 majors behind the latest version of France...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants