Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incompatible library enum34 #911

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Remove incompatible library enum34 #911

merged 2 commits into from
Nov 5, 2019

Conversation

bonjourmauko
Copy link
Member

Fixes #910

Deprecations

  • Remove the library enum34 from requirements
    • The library enum34 provides a backport of >= 3.4 enum to >= 2.7, < 3.4 Python environments.
    • The standard enum and enum34 are hence incompatible as installed under the same path.
    • Since we dropped support for <= 3.6, that library is no longer needed.

@bonjourmauko bonjourmauko added the kind:dependencies Pull requests that update a dependency file label Nov 4, 2019
Copy link
Contributor

@Br3nda Br3nda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@bonjourmauko bonjourmauko merged commit 08943bb into master Nov 5, 2019
@bonjourmauko bonjourmauko deleted the remove-enum34 branch November 5, 2019 12:11
@@ -1,5 +1,12 @@
# Changelog

## 34.5.1 [#911](https://github.com/openfisca/openfisca-core/pull/911)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh small mistake! :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web API installation fails with newer version of psutil
2 participants