Document & test eval_expression #1225

bonjourmauko · 2024-09-19T17:34:00Z

~~Depends on #1224~~

coveralls · 2024-09-19T17:35:45Z

coverage: 74.491% (-0.05%) from 74.538%
when pulling ecf904f on refactor-eval-expression
into eb154a0 on master.

bonjourmauko added level:starter Suited for beginners and new contributors kind:improvement Refactoring and code cleanup labels Sep 19, 2024

bonjourmauko added this to the Improved testing milestone Sep 19, 2024

bonjourmauko requested review from a team September 19, 2024 17:34

bonjourmauko self-assigned this Sep 19, 2024

bonjourmauko changed the base branch from master to fix-mypy-checks-enums September 19, 2024 17:34

bonjourmauko force-pushed the fix-mypy-checks-enums branch from 4a99cb4 to dad88a1 Compare September 20, 2024 15:47

bonjourmauko force-pushed the refactor-eval-expression branch from bd2e7d0 to bdc65ea Compare September 20, 2024 17:20

benjello approved these changes Sep 25, 2024

View reviewed changes

bonjourmauko added 6 commits September 25, 2024 16:31

chore(deps): update pendulum

a183a3a

refactor(types): do not use abstract classes

99ba51a

refactor(commons): reuse array type defs

9a43147

refactor(tools): move eval_expression to commons

66339b8

build(isort): fix imports config

5b9511f

doc(commons): add doctest to eval_expression

176afe3

bonjourmauko changed the base branch from fix-mypy-checks-enums to master September 25, 2024 16:01

bonjourmauko added 4 commits September 25, 2024 21:14

refactor(commons): fix linter warnings

277bd75

fix(commons): doc line length

52a2584

fix(entities): types

da1139e

chore(version): bump

ecf904f

bonjourmauko force-pushed the refactor-eval-expression branch from bdc65ea to ecf904f Compare September 25, 2024 19:15

bonjourmauko merged commit 7d451a1 into master Sep 25, 2024
22 checks passed

bonjourmauko deleted the refactor-eval-expression branch September 25, 2024 19:25

Provide feedback