-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parameters in command definitions in runner.yml #111
Comments
The relevant piece of code is in CollectionFactory::taskFactory() (I am posting specific commit ids to be sure this link still points to the same piece of code in the future) |
One could argue that the "old" version is actually shorter. |
Those are more "options" than "arguments". |
@donquixote the link you've provided in the description, is broken. Could you please send here the correct link or the code snippet. I would like to fill a PR. |
In #25 the option was added to define commands inside the runner.yml(.dist) file.
It would be nice if we could also add parameters to those commands.
Currently this has to be defined like so, by specifying the full cli command as a single string:
With support for parameters / arguments, it could look like this:
(The example is inspired from this, https://github.com/ec-europa/ecdc-vaccine-reference/blob/6cf99aec072e0b6616cc6a0967be692692c53103/src/TaskRunner/Commands/EcdcBuildCommands.php#L71)
The text was updated successfully, but these errors were encountered: