Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features flags and Settings changes between nutmeg to olive #204

Closed
ghassanmas opened this issue Oct 18, 2022 · 4 comments
Closed

Features flags and Settings changes between nutmeg to olive #204

ghassanmas opened this issue Oct 18, 2022 · 4 comments
Assignees
Labels
documentation Relates to documentation improvements
Milestone

Comments

@ghassanmas
Copy link
Member

ghassanmas commented Oct 18, 2022

This issue records the changes of featuers flags and settings between nutmeg and olive.
However this might nof include everything, since it captuers only settings/toggle that implement code-annotations.

New Features/Toggles

  1. ENABLE_DYNAMIC_REGISTRATION_FIELDS cms/envs/common.py#L588

  2. ENABLE_MFE_CONFIG_API lms/envs/common.py#L5192

  3. DISABLE_UNENROLLMENT cms/envs/common.py#L508

  4. ENABLE_CERTIFICATES_IDV_REQUIREMENT lms/envs/common.py#L1012

  5. SEND_CATALOG_INFO_SIGNAL cms/djangoapps/contentstore/signals/handlers.py#L55

  6. contentstore.bypass_olx_failure cms/djangoapps/contentstore/toggles.py#L39

  7. contentstore.individualize_anonymous_user_id cms/djangoapps/contentstore/toggles.py#L144

  8. contentstore.split_library_on_studio_dashboard cms/djangoapps/contentstore/toggles.py#L26

  9. course_apps.exams_ida openedx/core/djangoapps/course_apps/toggles.py#L22

  10. course_live.enable_big_blue_button openedx/core/djangoapps/course_live/config/waffle.py#L22

  11. credentials.use_learner_record_mfe openedx/core/djangoapps/credentials/config.py#L10

  12. discussions.enable_learners_stats lms/djangoapps/discussion/config/waffle.py#L9

  13. discussions.enable_reported_content_email_notifications lms/djangoapps/discussion/toggles.py#L38

  14. student.enable_2u_recommendations common/djangoapps/student/toggles.py#L2

  15. student.enable_amplitude_recommendations common/djangoapps/student/toggles.py#L9

  16. student.enable_redesign_enrollment_confirmation_email common/djangoapps/student/toggles.py#L43

Delete Features/Toggles

  1. bypass_olx_failure Note: proably relate to 6, 7, 8 above

  2. PersistentGradesEnabledFlag.enabled

  3. course_experience.latest_update

  4. course_home.course_home_use_legacy_frontend

  5. courseware.microfrontend_course_team_preview

  6. courseware.use_legacy_frontend

  7. grades.assume_zero_grade_if_absent

  8. split_library_on_studio_dashboard

New settings

  1. LEARNER_RECORD_MFE_URL /lms/envs/common.py#L4898
  2. MFE_CONFIG lms/envs/common.py#L5204
  3. MFE_CONFIG_API_CACHE_TIMEOUT lms/envs/common.py#L5244
  4. MFE_CONFIG_OVERRIDES lms/envs/common.py#L5225
  5. CUSTOM_RESOURCE_TEMPLATES_DIRECTORY cms/envs/common.py#L2141

Deleted Settings

  1. DISCUSSIONS_MFE_FEEDBACK_URL
@ghassanmas ghassanmas changed the title Featuers flags and Settings changes between nutmeg to olive Features flags and Settings changes between nutmeg to olive Oct 18, 2022
@pdpinch
Copy link

pdpinch commented Oct 18, 2022

Thanks @ghassanmas I was planning to build a similar list while working on the release notes. This saves me a lot of time.

Can you share your method for building this list?

@ghassanmas
Copy link
Member Author

@pdpinch yeah I knew it would helpful atleast for you.

from inside edx-platform repo

git checkout open-release/nutmeg.master
cd docs/technical 
make xml 
mv _build/xml xml-nutmege
git checkout open-release/olive.master
rm -rf _build
make xml 
mv _build/xml xml-olive
git diff xml-nutmeg xml-olive

Scanning the git diff of the last step, you will get an idea about the changes.
Note there will be a lot of noise because the changes of source url between edx to openedx and the warning which wasn't included nutmeg.

I think we can ultimately automate this process. On the bigger picture I persoally think having a mechanism of captuering those settings/toggles changes, default values, requirments, and to be able to debug an installation can be useful, i.e. you use a tool to tell you if your instance have the correct config/settings to use a certifan feature or if you have correct config/settings combination...etc.

@arbrandes
Copy link
Contributor

Is this issue something we should continue to be concerned about as Olive approaches, or is the work here done?

@arbrandes arbrandes added the documentation Relates to documentation improvements label Dec 6, 2022
@arbrandes
Copy link
Contributor

Closing this, as the Release Notes are now up for final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to documentation improvements
Projects
Development

No branches or pull requests

3 participants