fix: ignore touchstart events for closing modal popups

[brian-smith-tcril]

Description

Resolves #3081

react-focus-on was picking up touchstart events for onClickOutside - resulting in onClose being called before the click event was sent to the button. This PR just wraps the call to onClose in a small function that filters out touchstart events.

Deploy Preview

https://deploy-preview-3087--paragon-openedx.netlify.app/components/modal/modal-popup/

Merge Checklist

• If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
• Does your change adhere to the documented style conventions?
• Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
• Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
• Were your changes tested in the example app?
• Is there adequate test coverage for your changes?
• Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

• Verify your changes were released to NPM at the expected version.
• If you'd like, share your contribution in #show-and-tell.
• 🎉 🙌 Celebrate! Thanks for your contribution.

[netlify]

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	65bc658
🔍 Latest deploy log	https://app.netlify.com/sites/paragon-openedx/deploys/6668b5d0ff49030008feaedc
😎 Deploy Preview	https://deploy-preview-3087--paragon-openedx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (d4b08db) to head (65bc658).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3087   +/-   ##
=======================================
  Coverage   93.20%   93.21%           
=======================================
  Files         249      249           
  Lines        4359     4363    +4     
  Branches     1000     1037   +37     
=======================================
+ Hits         4063     4067    +4     
+ Misses        293      290    -3     
- Partials        3        6    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[adamstankiewicz]

LGTM, once we've verified the solution is cross-browser compatible as discussed in Paragon Working Group, at least according to the supported browsers in browserslist-config (source).

[brian-smith-tcril]

I have verified this on:

safari-ios-17.webm
safari-ios-16.webm
safari-ios-15.webm
firefox-android-12.webm
chrome-android-12.webm
chrome-mac-125.webm
chrome-mac-126.webm
firefox-mac-126.webm
firefox-mac-127.webm
edge-125.webm
edge-126.webm
safari-mac-16.5.webm
safari-mac-17.3.webm

I didn't test all 3 latest versions of Firefox and Chrome on Android, instead I just tested the third oldest, but I am confident this testing is enough to show the fix works.

[openedx-semantic-release-bot]

🎉 This PR is included in version 22.6.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀