Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alpha] Refactoring the generate-component script #2851

Closed
2 tasks
PKulkoRaccoonGang opened this issue Nov 23, 2023 · 4 comments
Closed
2 tasks

[alpha] Refactoring the generate-component script #2851

PKulkoRaccoonGang opened this issue Nov 23, 2023 · 4 comments
Labels
documentation Relates to documentation improvements raccoon-gang

Comments

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Nov 23, 2023

After switching to design tokens, in the Paragon repository (alpha branch), we stopped using the _variables.scss file in Paragon components. Given these changes, we must update the internal generate-component script in order to correctly generate the template for new components. This script still creates the _variables.scss.

image

We also need to update the documentation about the component generator on the corresponding page of the Paragon website

image
image

Tasks

@PKulkoRaccoonGang PKulkoRaccoonGang added raccoon-gang documentation Relates to documentation improvements labels Nov 23, 2023
@monteri
Copy link
Contributor

monteri commented Nov 28, 2023

Since we are not adding many components, will we need a "component generator"? I would consider deprecating the component generator altogether and removing it from the code base. 🤔

@adamstankiewicz
Copy link
Member

@adamstankiewicz Verify whether the Segment event with this CLI command is used by consumers.

@viktorrusakov
Copy link
Contributor

Let's not delete this script, it might be usefull in the future and it does not hurt anybody if it stays in the repository.

@PKulkoRaccoonGang please make these fixes, it will take you at most 10 minutes to do this 🙂

@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Jul 2, 2024

Resolved in: #3076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to documentation improvements raccoon-gang
Projects
None yet
Development

No branches or pull requests

4 participants