Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid filter in Usage Insights table #2694

Closed
viktorrusakov opened this issue Oct 6, 2023 · 1 comment
Closed

Invalid filter in Usage Insights table #2694

viktorrusakov opened this issue Oct 6, 2023 · 1 comment
Labels
bug Report of or fix for something that isn't working as intended documentation Relates to documentation improvements raccoon-gang

Comments

@viktorrusakov
Copy link
Contributor

When going to Usage Insights page it displays strange Paragon filter

image

It appears that some projects import all of Paragon components in tests as follows
image
which confuses our dependent usage analyzer.

This can be solved in one of the following ways:

  1. Improve dependent analyzer to understand such imports and extract the actual used components in the file (will likely require too much effort)
  2. Ignore files with such imports (such imports will probably only occur in tests and I don't think we particularly care how our components are used in tests)
  3. Ignore all test files (again, do we care how often Paragon components are used in tests? If not, maybe we can just skip such files)
@viktorrusakov viktorrusakov added bug Report of or fix for something that isn't working as intended raccoon-gang documentation Relates to documentation improvements labels Oct 6, 2023
@viktorrusakov viktorrusakov changed the title Invalid filter in Usage Insights table. Invalid filter in Usage Insights table Oct 6, 2023
@adamstankiewicz
Copy link
Member

We will close this as a won't do, because import * from '@edx/paragon'; is technically supported and having it show up in Usage Insights is good discoverability for when consumers do these imports.

If consumers want to import Paragon in this way for their tests (all the existing use cases thus far), this is likely OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended documentation Relates to documentation improvements raccoon-gang
Projects
Status: Done
Development

No branches or pull requests

2 participants