fix: non-relevant directories are added if conf/locale is missing #385
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
When python-translations is processed; we can have non-relevant directories added to the translation directory if `make extract_translations` did not generate the proper English directory at conf/locale Refs: FC-0012 OEP-58
shadinaif
force-pushed
the
shadinaif/fail-if-python-conf-is-missing
branch
from
ddfce3e
to
936b81a
Compare
|
@OmarIthawi @brian-smith-tcril please review |
There was a problem hiding this comment.
@shadinaif Looks like a great addition, thanks!
Please test it on a fork and share the results.
|
As you can see here @OmarIthawi , |
|
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Thanks @shadinaif!! Merged :) |
When python-translations is processed; we can have non-relevant directories added to the translation directory if
make extract_translationsdid not generate the proper English directory at conf/locale