Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] feat: add filters for roles management (1st approach) #103

Closed
wants to merge 2 commits into from

Conversation

mariajgrimaldi
Copy link
Member

Description

This PR adds filters aimed to be used for roles management in the main openedx services. Here's is an example of how they can be used:

They might be triggered by:
openedx/edx-platform@master...MJG/roles-refactor-by-filters

And with the following pipeline steps, we can add an additional role implemented in a plugin:
mariajgrimaldi/platform-plugin-sample@13a20ac

Configured using this Django setting:

OPEN_EDX_FILTERS_CONFIG = {
    "org.openedx.learning.instructor.dashboard.render.started.v1": {
        "fail_silently": False,
        "pipeline": [
            "platform_plugin_sample.extensions.filters.CheckProfessorRole",
        ]
    },

@openedx-webhooks openedx-webhooks added core committer open-source-contribution PR author is not from Axim or 2U labels Jul 18, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 18, 2023

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@mphilbrick211
Copy link

Hi @mariajgrimaldi! Just checking in to see if this is still needed?

@mariajgrimaldi
Copy link
Member Author

@mphilbrick211: thanks for the reminder! I'll close this for the time being

@mariajgrimaldi mariajgrimaldi deleted the MJG/roles-filters branch April 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core committer open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants