Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE]: Added script loader #708

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Jun 18, 2024

Description:

Script for adding custom scripts via the Django Site configurations.

  • Support global MFE_CONFIG and the MFE_CONFIG_OVERRIDES.
  • Support script adding via a link via src or inside the script tag.

Example:

{
    "MFE_CONFIG_OVERRIDES": {
        "<MFE>": {
            "EXTERNAL_SCRIPTS": [
                {
                    "head": "",
                    "body": {
                        "top": "",
                        "bottom": "<script src=\"https://ai-rnd-gpu-1.itl-dev.com/widget/loader.js\"></script>"
                    }
                }
            ]
        }
    }
}
{
    "MFE_CONFIG": {
        "EXTERNAL_SCRIPTS": [
            {
                "head": "",
                "body": {
                    "top": "",
                    "bottom": "<script src=\"https://ai-rnd-gpu-1.itl-dev.com/widget/loader.js\"></script>"
                }
            }
        ]
    }
}

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft June 18, 2024 11:17
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 18, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 18, 2024

Thanks for the pull request, @PKulkoRaccoonGang! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@ihor-romaniuk ihor-romaniuk force-pushed the Peter_Kulko/added-script-loader branch from aeadfbd to 29b15a8 Compare June 19, 2024 11:28
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title feat: added script loader [DO NOT MERGE]: Added script loader Jun 20, 2024
@openedx-webhooks
Copy link

@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@angonz
Copy link

angonz commented Oct 15, 2024

Hello!
I wonder why this feature was abandoned without merging. This is something I was looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants