-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated frontend-build to bump jest version to v29 #317
feat: Updated frontend-build to bump jest version to v29 #317
Conversation
…t-footer into bilalqamar95/frontend-build-jest-upgrade
9d91817
to
f99472b
Compare
…t-footer into bilalqamar95/frontend-build-jest-upgrade
…t-footer into bilalqamar95/frontend-build-jest-upgrade
package.json
Outdated
}, | ||
"peerDependencies": { | ||
"@edx/frontend-platform": "^7.0.0", | ||
"@edx/frontend-platform": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@edx/frontend-platform": "^8.0.0", | |
"@edx/frontend-platform": "^7.0.0 || ^8.0.0", |
i think we should add support of frontend-platform v7 here as well because a consumer will not break if it uses v7 or v8 of frontend-platform since frontend-platform v8 doesn't have any breaking changes except frontend-build peer dependency change. Moreover, we are opening PRs in respective MFEs as well with frontend-build and frontend-platform upgrade, i think we can handle this manually in those PRs. In this way we don't have to release it as a breaking change.
Description
jest
to v29 &frontend-build
major version upgradefrontend-platform
to v8