Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: version bump #921

Merged
merged 1 commit into from
Jan 12, 2024
Merged

chore: version bump #921

merged 1 commit into from
Jan 12, 2024

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Jan 11, 2024

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested review from adamstankiewicz and a team January 11, 2024 18:01
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (936d6ea) 84.33%.
Report is 122 commits behind head on master.

Files Patch % Lines
src/components/my-career/data/hooks.jsx 0.00% 12 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 71.42% 5 Missing and 1 partial ⚠️
src/components/app/App.jsx 0.00% 5 Missing ⚠️
src/components/app/EnterpriseAppPageRoutes.jsx 0.00% 5 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
src/components/academies/data/hooks.js 86.20% 4 Missing ⚠️
src/components/course/data/hooks.jsx 94.02% 4 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   84.87%   84.33%   -0.55%     
==========================================
  Files         320      343      +23     
  Lines        6399     7263     +864     
  Branches     1552     1780     +228     
==========================================
+ Hits         5431     6125     +694     
- Misses        941     1104     +163     
- Partials       27       34       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiram15 kiram15 merged commit b3ba8c5 into master Jan 12, 2024
5 of 6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-8123 branch January 12, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants