Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct spelling of canceled #912

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: correct spelling of canceled #912

merged 1 commit into from
Dec 19, 2023

Conversation

brobro10000
Copy link
Member

Updates instances of 'cancelled' to 'canceled'

Cool regex used (["'].*?)?[Cc]ancell?ed

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 145 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (02c37d0) 84.97%.
Report is 113 commits behind head on master.

Files Patch % Lines
src/components/search/Search.jsx 0.00% 29 Missing ⚠️
...ntent/course-enrollments/CourseAssignmentAlert.jsx 27.27% 8 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx 89.85% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...rc/components/search/AssignmentsOnlyEmptyState.jsx 0.00% 6 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 83.87% 5 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   84.87%   84.97%   +0.09%     
==========================================
  Files         320      337      +17     
  Lines        6399     7106     +707     
  Branches     1552     1738     +186     
==========================================
+ Hits         5431     6038     +607     
- Misses        941     1037      +96     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 merged commit 9c67c43 into master Dec 19, 2023
6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-8148 branch December 19, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants