fix: update redirect logic to take into account available coupon codes #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdiesel
approved these changes
Dec 14, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #906 +/- ##
==========================================
+ Coverage 84.87% 84.96% +0.09%
==========================================
Files 320 338 +18
Lines 6399 7091 +692
Branches 1552 1734 +182
==========================================
+ Hits 5431 6025 +594
- Misses 941 1035 +94
- Partials 27 31 +4 ☔ View full report in Codecov by Sentry. |
iloveagent57
approved these changes
Dec 14, 2023
adamstankiewicz
approved these changes
Dec 14, 2023
src/components/enterprise-user-subsidy/enterprise-offers/data/utils.js
Outdated
Show resolved
Hide resolved
brobro10000
force-pushed
the
hu/ent-that-darn-function-1
branch
from
804148d
to
b30f6a0
Compare
pwnage101
reviewed
Dec 14, 2023
Comment on lines
+152
to
154
| if (allocatedOrAcceptedAssignments?.length === 0) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Is this check redundant considering the next line already checks allocatedOrAcceptedAssignments?.length > 0 ? Perhaps the last line of this function can be simplified to just return activeOffers?.length > 0;?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates my favorite function,
isDisableCourseSearch, to take into account existing coupon codes before redirecting. If there exists an available coupon code, then we will not redirect away from the course about page.We also refactor the
isDisableCourseSearchto return out of the function as false (can view the course page) in the following order.nonAssignablePolicyTypeexist where anonAssignablePolicyTypeis not 'AssignedLearnerCreditAccessPolicy'hasActiveSubPlanwhere a subscription plan is active AND the subscription license status is 'activated'hasCouponCodeswhere a coupon code is available (active defined as the current date/time falls between a coupon start/end date)allocatedOrAcceptedAssignmentwhere an assignment state is either 'accepted' OR 'allocated'A user is redirected away from the course about page if either of the following conditions are true
activeOfferwhere an active offer is defined as a current offerallocatedOrAcceptedAssignmentwhere an assignment assignment state is either 'accepted' OR 'allocated'For all changes
Only if submitting a visual change