fix: ensure fetchEnterpriseCuration is only called if an enterpriseUUID is present #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
commented
Dec 13, 2023
| @@ -52,6 +52,10 @@ export const useEnterpriseCuration = (enterpriseUUID) => { | |||
| const [fetchError, setFetchError] = useState(); | |||
|
|
|||
| useEffect(() => { | |||
| if (!enterpriseUUID) { | |||
There was a problem hiding this comment.
If enterpriseUUID is not yet present, do nothing instead of calling the enterprise_curations API with undefined as its enterprise UUID, throwing lots of undefined is not a valid uuid errors in enterprise catalog.
Replicated the error locally; this conditional does indeed prevent the call.
bcitro
approved these changes
Dec 13, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #902 +/- ##
==========================================
+ Coverage 84.87% 84.94% +0.07%
==========================================
Files 320 338 +18
Lines 6399 7081 +682
Branches 1552 1732 +180
==========================================
+ Hits 5431 6015 +584
- Misses 941 1035 +94
- Partials 27 31 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes
Only if submitting a visual change