Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ENT-8091 hide course search in subsidy summary #894

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

irfanuddinahmad
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-8091 branch 3 times, most recently from 92df0bd to 5e93350 Compare December 12, 2023 10:25
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 109 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (f47629a) 85.22%.
Report is 100 commits behind head on master.

Files Patch % Lines
...ntent/course-enrollments/CourseAssignmentAlert.jsx 27.27% 8 Missing ⚠️
src/components/course/data/hooks.jsx 88.13% 7 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx 89.85% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 84.37% 5 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   84.87%   85.22%   +0.35%     
==========================================
  Files         320      336      +16     
  Lines        6399     7045     +646     
  Branches     1552     1729     +177     
==========================================
+ Hits         5431     6004     +573     
- Misses        941     1010      +69     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit/question on whether we need to sort the assignments here. Edit: also looks like CI is failing on linting

src/components/dashboard/sidebar/SubsidiesSummary.jsx Outdated Show resolved Hide resolved
@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-8091 branch 2 times, most recently from b9d2b9e to 1ebaca3 Compare December 12, 2023 16:25
@irfanuddinahmad irfanuddinahmad merged commit e8cdaf0 into master Dec 13, 2023
6 checks passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-8091 branch December 13, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants