Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: ENT-7367 Added new design for skills quiz #893

Closed
wants to merge 1 commit into from

Conversation

irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Dec 11, 2023

Description: This PR adds the new design for the skills quiz.

JIRA: ENT-7367

Screenshots:
image
image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@irfanuddinahmad irfanuddinahmad changed the title feat: ENT-7367 Added new design for skills quiz WIP: feat: ENT-7367 Added new design for skills quiz Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 186 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (6e0b98f) 84.50%.
Report is 116 commits behind head on master.

❗ Current head 6e0b98f differs from pull request most recent head 27ae279. Consider uploading reports for the commit 27ae279 to get more accurate results

Files Patch % Lines
src/components/search/Search.jsx 0.00% 29 Missing ⚠️
src/components/skills-quiz-v2/SkillsQuiz.jsx 3.70% 26 Missing ⚠️
...ntent/course-enrollments/CourseAssignmentAlert.jsx 27.27% 8 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx 89.85% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/skills-quiz-v2/GoalDropdown.jsx 12.50% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
... and 36 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   84.87%   84.50%   -0.37%     
==========================================
  Files         320      344      +24     
  Lines        6399     7158     +759     
  Branches     1552     1744     +192     
==========================================
+ Hits         5431     6049     +618     
- Misses        941     1077     +136     
- Partials       27       32       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants