Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct listPrice data #884

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: use correct listPrice data #884

merged 1 commit into from
Dec 6, 2023

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Dec 5, 2023

For all changes

Price on my assignment:
image

Course page with assignment's list price:
image

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (f507bc4) 85.10%.
Report is 91 commits behind head on master.

Files Patch % Lines
...ntent/course-enrollments/CourseAssignmentAlert.jsx 27.27% 8 Missing ⚠️
src/components/course/data/hooks.jsx 88.13% 7 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx 89.85% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 81.25% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...oard/main-content/course-enrollments/data/utils.js 81.48% 5 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   84.87%   85.10%   +0.23%     
==========================================
  Files         320      334      +14     
  Lines        6399     6970     +571     
  Branches     1552     1709     +157     
==========================================
+ Hits         5431     5932     +501     
- Misses        941     1007      +66     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iloveagent57 iloveagent57 force-pushed the aed/list-price branch 2 times, most recently from be78af7 to ca1a7d7 Compare December 6, 2023 14:16
Copy link
Member

@brobro10000 brobro10000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job 👍🏽

@iloveagent57 iloveagent57 merged commit 3a33122 into master Dec 6, 2023
6 checks passed
@iloveagent57 iloveagent57 deleted the aed/list-price branch December 6, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants