Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditionally text rendering while exec-ed course enrollments #882

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Dec 4, 2023

Description
While Exec-ed Assigned course enrollment, some text on the registration and confirm registration pages was not rendering. So here is the fix for that.

After Resolution:
image
image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (3b4bf9c) 84.99%.
Report is 86 commits behind head on master.

Files Patch % Lines
...ntent/course-enrollments/CourseAssignmentAlert.jsx 27.27% 8 Missing ⚠️
src/components/course/data/hooks.jsx 87.93% 7 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 80.00% 7 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx 89.85% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   84.87%   84.99%   +0.11%     
==========================================
  Files         320      327       +7     
  Lines        6399     6876     +477     
  Branches     1552     1684     +132     
==========================================
+ Hits         5431     5844     +413     
- Misses        941     1001      +60     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 merged commit faf83a5 into master Dec 4, 2023
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-7669-3 branch December 4, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants