Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated course card resume button variant #870

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

mahamakifdar19
Copy link
Contributor

Jira Ticket: https://2u-internal.atlassian.net/browse/ENT-7843
Description: Changed course card resume/start button variant from "primary" to "outline-primary" so that its not overridden by theme colors.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (bd4aa14) 85.13%.
Report is 78 commits behind head on master.

Files Patch % Lines
src/components/course/data/hooks.jsx 87.93% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 82.60% 4 Missing ⚠️
src/components/my-career/SearchJobRole.jsx 91.48% 4 Missing ⚠️
...ourse-header/data/hooks/useCourseRunCardAction.jsx 50.00% 3 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   84.87%   85.13%   +0.25%     
==========================================
  Files         320      325       +5     
  Lines        6399     6793     +394     
  Branches     1552     1652     +100     
==========================================
+ Hits         5431     5783     +352     
- Misses        941      979      +38     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 merged commit 4b08e4c into master Nov 21, 2023
6 checks passed
@mahamakifdar19 mahamakifdar19 deleted the mahamakif/ENT-7843-button-variant-fix branch November 21, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants