Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-applied subs #855

Merged
merged 3 commits into from
Oct 19, 2023
Merged

fix: auto-applied subs #855

merged 3 commits into from
Oct 19, 2023

Conversation

adamstankiewicz
Copy link
Member

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (0207e7a) 85.01%.
Report is 78 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
+ Coverage   84.87%   85.01%   +0.14%     
==========================================
  Files         320      325       +5     
  Lines        6399     6742     +343     
  Branches     1552     1635      +83     
==========================================
+ Hits         5431     5732     +301     
- Misses        941      979      +38     
- Partials       27       31       +4     
Files Coverage Δ
src/components/contact-admin-mailto/index.jsx 100.00% <100.00%> (ø)
src/components/course/CourseContextProvider.jsx 100.00% <100.00%> (ø)
src/components/course/CourseMainContent.jsx 100.00% <ø> (ø)
src/components/course/CoursePage.jsx 93.75% <100.00%> (ø)
src/components/course/CourseRecommendationCard.jsx 96.00% <100.00%> (+0.16%) ⬆️
src/components/course/CourseSidebar.jsx 100.00% <100.00%> (ø)
src/components/course/CourseSidebarListItem.jsx 100.00% <ø> (ø)
src/components/course/EnrollModal.jsx 93.54% <100.00%> (ø)
src/components/course/VerifiedCertPitch.jsx 100.00% <ø> (ø)
...c/components/course/course-header/CourseHeader.jsx 100.00% <100.00%> (ø)
... and 126 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit dee92ae into master Oct 19, 2023
6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/ent-7845 branch October 19, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants