feat: added course card, job card and alert modal #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zamanafzal
force-pushed
the
zafzal/ENT-7365
branch
from
18f2ce2
to
516b6d1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## zafzal/ENT7364 #809 +/- ##
=================================================
Coverage ? 84.59%
=================================================
Files ? 327
Lines ? 6642
Branches ? 1614
=================================================
Hits ? 5619
Misses ? 991
Partials ? 32 ☔ View full report in Codecov by Sentry. |
|
@zamanafzal It looks like the space below the modal buttons is different from space above the modal title? Can we make it same? |
zamanafzal
force-pushed
the
zafzal/ENT-7365
branch
from
516b6d1
to
86765c9
Compare
|
@muhammad-ammar Yes, Updated. |
jajjibhai008
approved these changes
Aug 16, 2023
Now the bottom has more space then top :) |
zamanafzal
force-pushed
the
zafzal/ENT-7365
branch
from
86765c9
to
b1302e0
Compare
|
@muhammad-ammar It actually is the same 40px. |
zamanafzal
force-pushed
the
zafzal/ENT-7365
branch
from
b1302e0
to
9363cd9
Compare
muhammad-ammar
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes
Only if submitting a visual change