Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9342, ENT-9338] Video transcript updates #1160

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

mahamakifdar19
Copy link
Contributor

Tickets

Description

  • Updated the videos to have a default transcript language that matches the browser's default.
  • Fixed an issue where video player controls were missing for a specific video due to inconsistent size.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-9342 branch 2 times, most recently from d642545 to e44c079 Compare August 21, 2024 08:03
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (8dafafc) to head (3f995fe).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1160      +/-   ##
==========================================
+ Coverage   88.05%   88.09%   +0.04%     
==========================================
  Files         394      394              
  Lines        8338     8359      +21     
  Branches     2008     2058      +50     
==========================================
+ Hits         7342     7364      +22     
+ Misses        954      952       -2     
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 merged commit 9e9ef9b into master Aug 21, 2024
7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-9342 branch August 21, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants