From da89e3f03cb2172808fef9fd7af73834514a13d6 Mon Sep 17 00:00:00 2001 From: Hamzah Ullah Date: Thu, 14 Dec 2023 10:15:02 -0500 Subject: [PATCH] chore: PR fixes --- src/components/course/routes/ExternalCourseEnrollment.jsx | 3 +-- .../course/routes/tests/ExternalCourseEnrollment.test.jsx | 4 ---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/components/course/routes/ExternalCourseEnrollment.jsx b/src/components/course/routes/ExternalCourseEnrollment.jsx index 6a99c8e879..202c3c1919 100644 --- a/src/components/course/routes/ExternalCourseEnrollment.jsx +++ b/src/components/course/routes/ExternalCourseEnrollment.jsx @@ -66,13 +66,12 @@ const ExternalCourseEnrollment = () => { containerRef.current.scrollIntoView({ behavior: 'smooth' }); } }, [externalCourseFormSubmissionError, containerRef]); - useEffect(() => { // Once a redemption has successfully completed and the can-redeem query has been invalidated or // a user attempts to navigate directly to :slug/executive-education-2u/course/:courseKey/enroll, // it will run this conditional and perform the redirect if (hasSuccessfulRedemption) { - history.push({ pathname: completeEnrollmentUrl }); + history.push(completeEnrollmentUrl); } }, [completeEnrollmentUrl, course.key, hasSuccessfulRedemption, history, routeMatch.path, slug]); diff --git a/src/components/course/routes/tests/ExternalCourseEnrollment.test.jsx b/src/components/course/routes/tests/ExternalCourseEnrollment.test.jsx index 35eadde50f..097d6977cd 100644 --- a/src/components/course/routes/tests/ExternalCourseEnrollment.test.jsx +++ b/src/components/course/routes/tests/ExternalCourseEnrollment.test.jsx @@ -120,13 +120,9 @@ describe('ExternalCourseEnrollment', () => { expect(screen.getByTestId('user-enrollment-form')).toBeInTheDocument(); expect(UserEnrollmentForm.mock.calls[0][0]).toEqual( expect.objectContaining({ - onCheckoutSuccess: expect.any(Function), productSKU: 'test-sku', }), ); - UserEnrollmentForm.mock.calls[0][0].onCheckoutSuccess(); - expect(mockHistoryPush).toHaveBeenCalledTimes(1); - expect(mockHistoryPush).toHaveBeenCalledWith('enroll/complete'); }); it.each([