{
return width < breakpoints.small.minWidth;
};
-export const useShowRecommendationsFooter = () => {
- const hasAvailableDashboards = reduxHooks.useHasAvailableDashboards();
- const hasRequestCompleted = reduxHooks.useRequestIsCompleted(RequestKeys.initialize);
-
- return {
- shouldShowFooter: false,
- shouldLoadFooter: hasRequestCompleted && !hasAvailableDashboards,
- };
-};
-
export const useMostRecentCourseRunKey = () => {
const mostRecentCourseRunKey = reduxHooks.useCurrentCourseList({
sortBy: SortKeys.enrolled,
@@ -37,6 +34,61 @@ export const useMostRecentCourseRunKey = () => {
return mostRecentCourseRunKey;
};
+export const useActivateRecommendationsExperiment = () => {
+ const enterpriseDashboardData = reduxHooks.useEnterpriseDashboardData();
+ const hasRequestCompleted = reduxHooks.useRequestIsCompleted(RequestKeys.initialize);
+ const mostRecentCourseRunKey = module.useMostRecentCourseRunKey();
+ const userId = getAuthenticatedUser().userId.toString();
+
+ const {
+ experiment: { isExperimentActive },
+ setExperiment,
+ isMobile,
+ countryCode,
+ } = useExperimentContext();
+
+ useEffect(() => {
+ if (!isExperimentActive && countryCode !== null) {
+ const activateExperiment = () => {
+ const userAttributes = {
+ is_mobile_user: isMobile,
+ is_enterprise_user: !!enterpriseDashboardData,
+ location: countryCode ? countryCode.toLowerCase() : '',
+ };
+ const experiment = activateProductRecommendationsExperiment(userId, userAttributes);
+
+ setExperiment((prev) => ({
+ ...prev,
+ isExperimentActive: true,
+ inRecommendationsVariant: experiment.inExperimentVariant,
+ }));
+
+ return experiment;
+ };
+
+ const sendViewedEvent = () => {
+ trackProductRecommendationsViewed(userId);
+ recommendationsViewed(true, control, mostRecentCourseRunKey);
+ };
+
+ if (hasRequestCompleted) {
+ const { experimentActivated, inExperimentVariant } = activateExperiment();
+
+ if (experimentActivated && !inExperimentVariant) {
+ sendViewedEvent();
+ }
+ }
+ }
+ /* eslint-disable */
+ }, [isExperimentActive, countryCode])
+};
+
+export const useShowRecommendationsFooter = () => {
+ const { experiment } = useExperimentContext();
+
+ return experiment;
+};
+
export const useFetchRecommendations = (setRequestState, setData) => {
const courseRunKey = module.useMostRecentCourseRunKey();
@@ -74,10 +126,29 @@ export const useFetchRecommendations = (setRequestState, setData) => {
}, []);
};
+export const useSendViewedEvents = (requestState, data) => {
+ const mostRecentCourseRunKey = module.useMostRecentCourseRunKey();
+ const userId = getAuthenticatedUser().userId.toString();
+
+ useEffect(() => {
+ if (requestState === RequestStates.completed) {
+ if (data.crossProductCourses?.length === 2) {
+ trackProductRecommendationsViewed(userId);
+ recommendationsViewed(false, treatment, mostRecentCourseRunKey);
+ } else {
+ trackProductRecommendationsViewed(userId);
+ recommendationsViewed(true, noExperiment, mostRecentCourseRunKey);
+ }
+ }
+ }, [data, requestState])
+}
+
export const useProductRecommendationsData = () => {
const [requestState, setRequestState] = module.state.requestState(RequestStates.pending);
const [data, setData] = module.state.data({});
+
module.useFetchRecommendations(setRequestState, setData);
+ module.useSendViewedEvents(requestState, data);
return {
productRecommendations: data,
@@ -87,4 +158,4 @@ export const useProductRecommendationsData = () => {
};
};
-export default { useProductRecommendationsData, useShowRecommendationsFooter, useIsMobile };
+export default { useProductRecommendationsData, useShowRecommendationsFooter, useIsMobile, useActivateRecommendationsExperiment };
diff --git a/src/widgets/ProductRecommendations/hooks.test.js b/src/widgets/ProductRecommendations/hooks.test.js
index dc4d497c..111337dc 100644
--- a/src/widgets/ProductRecommendations/hooks.test.js
+++ b/src/widgets/ProductRecommendations/hooks.test.js
@@ -5,7 +5,13 @@ import { MockUseState } from 'testUtils';
import { RequestStates } from 'data/constants/requests';
import { reduxHooks } from 'hooks';
import { useWindowSize } from '@edx/paragon';
+import { getAuthenticatedUser } from '@edx/frontend-platform/auth';
+import { useExperimentContext } from 'ExperimentContext';
+import { recommendationsViewed } from './track';
+import { activateProductRecommendationsExperiment, trackProductRecommendationsViewed } from './optimizelyExperiment';
+import { control, treatment, noExperiment } from './constants';
import { wait } from './utils';
+import { mockCrossProductResponse, mockAmplitudeResponse } from './testData';
import api from './api';
import * as hooks from './hooks';
@@ -13,16 +19,34 @@ import * as hooks from './hooks';
jest.mock('./api', () => ({
fetchCrossProductRecommendations: jest.fn(),
fetchAmplitudeRecommendations: jest.fn(),
+ fetchRecommendationsContext: jest.fn(),
+}));
+
+jest.mock('@edx/frontend-platform/auth', () => ({
+ getAuthenticatedUser: jest.fn(),
+}));
+
+jest.mock('ExperimentContext', () => ({
+ useExperimentContext: jest.fn(),
}));
jest.mock('hooks', () => ({
reduxHooks: {
useCurrentCourseList: jest.fn(),
- useHasAvailableDashboards: jest.fn(),
+ useEnterpriseDashboardData: jest.fn(),
useRequestIsCompleted: jest.fn(),
},
}));
+jest.mock('./track', () => ({
+ recommendationsViewed: jest.fn(),
+}));
+
+jest.mock('./optimizelyExperiment', () => ({
+ trackProductRecommendationsViewed: jest.fn(),
+ activateProductRecommendationsExperiment: jest.fn(),
+}));
+
const state = new MockUseState(hooks);
const mostRecentCourseRunKey = 'course ID 1';
@@ -53,6 +77,7 @@ let output;
describe('ProductRecommendations hooks', () => {
beforeEach(() => {
jest.resetAllMocks();
+ getAuthenticatedUser.mockImplementation(() => ({ userId: '1' }));
});
describe('state fields', () => {
@@ -86,14 +111,175 @@ describe('ProductRecommendations hooks', () => {
});
describe('useShowRecommendationsFooter', () => {
- // TODO: Update when hardcoded value is removed
- it('returns whether the footer widget should show and should load', () => {
- reduxHooks.useHasAvailableDashboards.mockReturnValueOnce(false);
- reduxHooks.useRequestIsCompleted.mockReturnValueOnce(true);
- const { shouldShowFooter, shouldLoadFooter } = hooks.useShowRecommendationsFooter();
-
- expect(shouldShowFooter).toBeFalsy();
- expect(shouldLoadFooter).toBeTruthy();
+ it('returns the experiment object, stating if the experiment has activated and the variant', () => {
+ useExperimentContext
+ .mockImplementationOnce(() => ({ experiment: { inRecommendationsVariant: true, isExperimentActive: false } }));
+
+ const { inRecommendationsVariant, isExperimentActive } = hooks.useShowRecommendationsFooter();
+
+ expect(useExperimentContext).toHaveBeenCalled();
+ expect(inRecommendationsVariant).toBeTruthy();
+ expect(isExperimentActive).toBeFalsy();
+ });
+ });
+
+ describe('useActivateRecommendationsExperiment', () => {
+ describe('behavior', () => {
+ describe('useEffect call', () => {
+ let cb;
+ let calls;
+ let prereqs;
+ const setExperiment = jest.fn();
+ const setCountryCode = jest.fn();
+ const userAttributes = { is_enterprise_user: false, is_mobile_user: false, location: 'za' };
+
+ const optimizelyExperimentMock = ({
+ experimentActivated = false,
+ inExperimentVariant = false,
+ }) => ({
+ experimentActivated,
+ inExperimentVariant,
+ });
+
+ const experimentContextMock = ({
+ isExperimentActive = false,
+ inRecommendationsVariant = true,
+ countryCode = 'ZA',
+ isMobile = false,
+ }) => ({
+ experiment: { isExperimentActive, inRecommendationsVariant },
+ countryCode,
+ isMobile,
+ setExperiment,
+ setCountryCode,
+ });
+
+ const setUp = (
+ isCompleted,
+ experimentContext = experimentContextMock({}),
+ optimizelyExperiment = optimizelyExperimentMock({}),
+ ) => {
+ reduxHooks.useCurrentCourseList.mockReturnValueOnce(populatedCourseListData);
+ reduxHooks.useEnterpriseDashboardData.mockReturnValueOnce(null);
+ reduxHooks.useRequestIsCompleted.mockReturnValueOnce(isCompleted);
+ useExperimentContext.mockReturnValueOnce(experimentContext);
+ activateProductRecommendationsExperiment.mockReturnValueOnce(optimizelyExperiment);
+
+ hooks.useActivateRecommendationsExperiment();
+
+ ({ calls } = React.useEffect.mock);
+ ([[cb, prereqs]] = calls);
+ };
+
+ it('runs when isExperimentActive or countryCode changes (prereqs)', () => {
+ setUp(true);
+ expect(prereqs).toEqual([false, 'ZA']);
+ expect(calls.length).toEqual(1);
+ });
+ describe('when the request state is not completed', () => {
+ it('does not activate or send any events', () => {
+ setUp(false);
+ cb();
+ expect(activateProductRecommendationsExperiment).not.toHaveBeenCalled();
+ expect(trackProductRecommendationsViewed).not.toHaveBeenCalled();
+ expect(recommendationsViewed).not.toHaveBeenCalled();
+ });
+ });
+ describe('when the experiment is active', () => {
+ it('does not activate or send any events', () => {
+ setUp(true, experimentContextMock({ isExperimentActive: true }));
+ cb();
+ expect(activateProductRecommendationsExperiment).not.toHaveBeenCalled();
+ expect(trackProductRecommendationsViewed).not.toHaveBeenCalled();
+ expect(recommendationsViewed).not.toHaveBeenCalled();
+ });
+ });
+ describe('when the experiment is inactive but user country code has not been fetched', () => {
+ it('does not activate or send any events', () => {
+ setUp(true, experimentContextMock({ countryCode: null }));
+ cb();
+ expect(activateProductRecommendationsExperiment).not.toHaveBeenCalled();
+ expect(trackProductRecommendationsViewed).not.toHaveBeenCalled();
+ expect(recommendationsViewed).not.toHaveBeenCalled();
+ });
+ });
+ describe('when the experiment is inactive and user country code has been fetched', () => {
+ it('activates the experiment and sends viewed event for control group', () => {
+ setUp(
+ true,
+ experimentContextMock({}),
+ optimizelyExperimentMock({ experimentActivated: true, inExperimentVariant: false }),
+ );
+ cb();
+ expect(activateProductRecommendationsExperiment).toHaveBeenCalledWith('1', userAttributes);
+ expect(setExperiment).toHaveBeenCalled();
+ expect(trackProductRecommendationsViewed).toHaveBeenCalledWith('1');
+ expect(recommendationsViewed).toHaveBeenCalledWith(true, control, mostRecentCourseRunKey);
+ });
+ it('activates the experiment and does not sends viewed event for treatment group', () => {
+ setUp(
+ true,
+ experimentContextMock({ countryCode: '' }),
+ optimizelyExperimentMock({ experimentActivated: true, inExperimentVariant: true }),
+ );
+ cb();
+ expect(activateProductRecommendationsExperiment).toHaveBeenCalledWith('1', { ...userAttributes, location: '' });
+ expect(setExperiment).toHaveBeenCalled();
+ expect(trackProductRecommendationsViewed).not.toHaveBeenCalled();
+ expect(recommendationsViewed).not.toHaveBeenCalled();
+ });
+ });
+ });
+ });
+ });
+
+ describe('useSendViewedEvents', () => {
+ describe('behavior', () => {
+ describe('useEffect call', () => {
+ let cb;
+ let calls;
+ let prereqs;
+ const { completed, pending } = RequestStates;
+
+ const setUp = (requestState, response) => {
+ reduxHooks.useCurrentCourseList.mockReturnValueOnce(populatedCourseListData);
+ hooks.useSendViewedEvents(requestState, response);
+ ({ calls } = React.useEffect.mock);
+ ([[cb, prereqs]] = calls);
+ };
+
+ it('runs when data or requestState changes (prereqs)', () => {
+ setUp(completed, mockCrossProductResponse);
+ expect(prereqs).toEqual([mockCrossProductResponse, completed]);
+ expect(calls.length).toEqual(1);
+ });
+ describe('when the request state is not completed', () => {
+ it('does not send any events', () => {
+ setUp(pending, mockCrossProductResponse);
+ cb();
+ expect(trackProductRecommendationsViewed).not.toHaveBeenCalled();
+ expect(recommendationsViewed).not.toHaveBeenCalled();
+ });
+ });
+ describe('when the request state is completed', () => {
+ describe('with crossProduct data that has 2 cross product courses', () => {
+ it('sends out recommendations viewed event for "treatment" group', () => {
+ setUp(completed, mockCrossProductResponse);
+ cb();
+ expect(trackProductRecommendationsViewed).toHaveBeenCalledWith('1');
+ expect(recommendationsViewed).toHaveBeenCalledWith(false, treatment, mostRecentCourseRunKey);
+ });
+ });
+ describe('with amplitude data and no cross product data', () => {
+ it('sends out recommendations viewed event for "no experiment" group', () => {
+ setUp(completed, mockAmplitudeResponse);
+ cb();
+ expect(trackProductRecommendationsViewed).toHaveBeenCalledWith('1');
+ expect(recommendationsViewed).toHaveBeenCalledWith(true, noExperiment, mostRecentCourseRunKey);
+ });
+ });
+ });
+ });
});
});
@@ -281,14 +467,19 @@ describe('ProductRecommendations hooks', () => {
});
});
describe('useProductRecommendationsData', () => {
- let fetchSpy;
+ let fetchRecommendationsSpy;
+ let sendViewedEventsSpy;
beforeEach(() => {
state.mock();
- fetchSpy = jest.spyOn(hooks, 'useFetchRecommendations').mockImplementationOnce(() => {});
+ fetchRecommendationsSpy = jest.spyOn(hooks, 'useFetchRecommendations').mockImplementationOnce(() => {});
+ sendViewedEventsSpy = jest.spyOn(hooks, 'useSendViewedEvents').mockImplementationOnce(() => {});
output = hooks.useProductRecommendationsData();
});
it('calls useFetchRecommendations with setRequestState and setData', () => {
- expect(fetchSpy).toHaveBeenCalledWith(state.setState.requestState, state.setState.data);
+ expect(fetchRecommendationsSpy).toHaveBeenCalledWith(state.setState.requestState, state.setState.data);
+ });
+ it('calls useFetchViewedEvents with requestState and data', () => {
+ expect(sendViewedEventsSpy).toHaveBeenCalledWith(state.stateVals.requestState, state.stateVals.data);
});
it('initializes requestState as RequestStates.pending', () => {
state.expectInitializedWith(state.keys.requestState, RequestStates.pending);
diff --git a/src/widgets/ProductRecommendations/optimizelyExperiment.js b/src/widgets/ProductRecommendations/optimizelyExperiment.js
index 93cb6d13..72b0b314 100644
--- a/src/widgets/ProductRecommendations/optimizelyExperiment.js
+++ b/src/widgets/ProductRecommendations/optimizelyExperiment.js
@@ -18,7 +18,10 @@ export const activateProductRecommendationsExperiment = (userId, userAttributes)
userAttributes,
);
- return variation === PRODUCT_RECOMMENDATIONS_EXP_VARIATION;
+ return {
+ experimentActivated: variation !== null,
+ inExperimentVariant: variation === PRODUCT_RECOMMENDATIONS_EXP_VARIATION,
+ };
};
export const trackProductRecommendationsViewed = (userId, userAttributes = {}) => {
diff --git a/src/widgets/ProductRecommendations/optimizelyExperiment.test.js b/src/widgets/ProductRecommendations/optimizelyExperiment.test.js
index ec12205f..dbd57d92 100644
--- a/src/widgets/ProductRecommendations/optimizelyExperiment.test.js
+++ b/src/widgets/ProductRecommendations/optimizelyExperiment.test.js
@@ -24,11 +24,25 @@ const userAttributes = {
describe('Optimizely events', () => {
describe('activateProductRecommendationsExperiment', () => {
- it('activates the experiment and returns in recommendations experiment variant', () => {
+ it('activates the experiment and returns in experiment variant', () => {
optimizelyClient.activate.mockReturnValueOnce(PRODUCT_RECOMMENDATIONS_EXP_VARIATION);
- const inRecommendationsVariant = activateProductRecommendationsExperiment(userId, userAttributes);
+ const experiment = activateProductRecommendationsExperiment(userId, userAttributes);
- expect(inRecommendationsVariant).toBeTruthy();
+ expect(experiment.experimentActivated).toBeTruthy();
+ expect(experiment.inExperimentVariant).toBeTruthy();
+ expect(optimizelyClient.activate).toHaveBeenCalledWith(
+ PRODUCT_RECOMMENDATIONS_EXP_KEY,
+ userId,
+ userAttributes,
+ );
+ });
+
+ it('does not activate the experiment and returns not in experiment variant', () => {
+ optimizelyClient.activate.mockReturnValueOnce(null);
+ const experiment = activateProductRecommendationsExperiment(userId, userAttributes);
+
+ expect(experiment.experimentActivated).toBeFalsy();
+ expect(experiment.inExperimentVariant).toBeFalsy();
expect(optimizelyClient.activate).toHaveBeenCalledWith(
PRODUCT_RECOMMENDATIONS_EXP_KEY,
userId,
diff --git a/src/widgets/ProductRecommendations/testData.js b/src/widgets/ProductRecommendations/testData.js
index 2f85013f..45739a28 100644
--- a/src/widgets/ProductRecommendations/testData.js
+++ b/src/widgets/ProductRecommendations/testData.js
@@ -1,11 +1,14 @@
-export const getCoursesWithType = (courseTypes) => {
+export const getCoursesWithType = (courseTypes, parameters = true) => {
const courses = [];
+ const marketingUrl = parameters
+ ? 'https://www.edx.org/course/some-course?utm_source=source'
+ : 'https://www.edx.org/course/some-course';
courseTypes.forEach((type) => {
courses.push({
title: 'Introduction to Computer Science',
courseRunKey: 'course-v1:Test+Course+2022T2',
- marketingUrl: 'https://www.edx.org/course/some-course?utm_source=source',
+ marketingUrl,
courseType: type,
image: {
src: 'https://www.image-2.com/ed79a49b-64c1-48d2-afdc-054bf921e38d-6a76ceb47dea.small.jpg',
@@ -24,14 +27,14 @@ export const getCoursesWithType = (courseTypes) => {
};
export const mockFooterRecommendationsHook = {
- showAndLoad: { shouldShowFooter: true, shouldLoadFooter: true },
- showDontLoad: { shouldShowFooter: true, shouldLoadFooter: false },
- loadDontShow: { shouldShowFooter: false, shouldLoadFooter: true },
- dontShowOrLoad: { shouldShowFooter: false, shouldLoadFooter: false },
+ default: { isExperimentActive: false, inRecommendationsVariant: true },
+ activeControl: { isExperimentActive: true, inRecommendationsVariant: false },
+ activeTreatment: { isExperimentActive: true, inRecommendationsVariant: true },
};
export const mockCrossProductCourses = getCoursesWithType(['executive-education-2u', 'bootcamp-2u']);
export const mockOpenCourses = getCoursesWithType(['verified-audit', 'audit', 'verified', 'course']);
+export const mockFallbackOpenCourse = getCoursesWithType(['course'], false);
export const mockCrossProductResponse = {
crossProductCourses: mockCrossProductCourses,
diff --git a/src/widgets/ProductRecommendations/track.js b/src/widgets/ProductRecommendations/track.js
index df0cf508..6afe2926 100644
--- a/src/widgets/ProductRecommendations/track.js
+++ b/src/widgets/ProductRecommendations/track.js
@@ -12,7 +12,6 @@ export const eventNames = StrictDict({
export const productCardClicked = (courseRunKey, courseTitle, courseType, href) => {
createLinkTracker(
createEventTracker(eventNames.productCardClicked, {
- category: 'recommender',
label: courseTitle,
courserun_key: courseRunKey,
page: 'dashboard',
@@ -25,7 +24,6 @@ export const productCardClicked = (courseRunKey, courseTitle, courseType, href)
export const discoveryCardClicked = (courseRunKey, courseTitle, href) => {
createLinkTracker(
createEventTracker(eventNames.discoveryCardClicked, {
- category: 'recommender',
label: courseTitle,
courserun_key: courseRunKey,
page: 'dashboard',
@@ -38,7 +36,6 @@ export const discoveryCardClicked = (courseRunKey, courseTitle, href) => {
export const recommendationsHeaderClicked = (courseType, href) => {
createLinkTracker(
createEventTracker(eventNames.recommendationsHeaderClicked, {
- category: 'recommender',
page: 'dashboard',
product_line: courseTypeToProductLineMap[courseType],
}),
@@ -46,10 +43,11 @@ export const recommendationsHeaderClicked = (courseType, href) => {
);
};
-export const recommendationsViewed = (isControl, courseRunKey) => {
+export const recommendationsViewed = (isControl, recommenderGroup, courseRunKey) => {
createEventTracker(eventNames.recommendationsViewed, {
is_control: isControl,
+ productRecommenderGroup: recommenderGroup,
page: 'dashboard',
- course_key: convertCourseRunKeyToCourseKey(courseRunKey),
+ course_key: courseRunKey ? convertCourseRunKeyToCourseKey(courseRunKey) : '',
});
};
diff --git a/src/widgets/ProductRecommendations/track.test.js b/src/widgets/ProductRecommendations/track.test.js
index 58bf4a80..7fcd5834 100644
--- a/src/widgets/ProductRecommendations/track.test.js
+++ b/src/widgets/ProductRecommendations/track.test.js
@@ -1,4 +1,5 @@
import { createLinkTracker, createEventTracker } from 'data/services/segment/utils';
+import { bootCamp, treatment, control } from './constants';
import {
eventNames,
productCardClicked,
@@ -18,17 +19,17 @@ const courseRunKeyOld = 'MITx/5.0.01/2022T2/';
const label = 'Web Design';
const headerLink = 'https://www.edx.org/search?tab=course?linked_from=recommender';
const courseUrl = 'https://www.edx.org/course/some-course';
-const category = 'recommender';
describe('product recommendations trackers', () => {
describe('recommendationsViewed', () => {
describe('with old course run key format', () => {
it('creates an event tracker for when cross product recommendations are present', () => {
- recommendationsViewed(false, courseRunKeyOld);
+ recommendationsViewed(false, treatment, courseRunKeyOld);
expect(createEventTracker).toHaveBeenCalledWith(
eventNames.recommendationsViewed,
{
is_control: false,
+ productRecommenderGroup: treatment,
page: 'dashboard',
course_key: courseKey,
},
@@ -36,23 +37,38 @@ describe('product recommendations trackers', () => {
});
});
describe('with new course run key format', () => {
- it('creates an event tracker for when cross product recommendations are present', () => {
- recommendationsViewed(false, courseRunKeyNew);
+ it('creates an event tracker for when a user is bucketed into the conrol group', () => {
+ recommendationsViewed(false, control, courseRunKeyNew);
+
expect(createEventTracker).toHaveBeenCalledWith(
eventNames.recommendationsViewed,
{
is_control: false,
+ productRecommenderGroup: control,
page: 'dashboard',
course_key: courseKey,
},
);
});
});
+ describe('with no course run key', () => {
+ it('creates an event tracker for when a user is bucketed into the conrol group', () => {
+ recommendationsViewed(false, control, '');
+ expect(createEventTracker).toHaveBeenCalledWith(
+ eventNames.recommendationsViewed,
+ {
+ is_control: false,
+ productRecommenderGroup: control,
+ page: 'dashboard',
+ course_key: '',
+ },
+ );
+ });
+ });
});
describe('recommendationsHeaderClicked', () => {
it('creates a link tracker for when a recommendations header is clicked', () => {
const attributes = {
- category,
product_line: 'open-courses',
page: 'dashboard',
};
@@ -66,7 +82,6 @@ describe('product recommendations trackers', () => {
describe('discoveryCardClicked', () => {
it('creates a link tracker for when a open course card is clicked', () => {
const attributes = {
- category,
label,
courserun_key: courseRunKeyNew,
page: 'dashboard',
@@ -82,7 +97,6 @@ describe('product recommendations trackers', () => {
describe('productCardClicked', () => {
it('creates a link tracker for when a cross product course card is clicked', () => {
const attributes = {
- category,
label,
courserun_key: courseRunKeyNew,
page: 'dashboard',
@@ -90,7 +104,7 @@ describe('product recommendations trackers', () => {
};
const args = [eventNames.productCardClicked, attributes];
- productCardClicked(courseRunKeyNew, label, 'Boot Camp', courseUrl);
+ productCardClicked(courseRunKeyNew, label, bootCamp, courseUrl);
expect(createEventTracker).toHaveBeenCalledWith(...args);
expect(createLinkTracker).toHaveBeenCalledWith(createEventTracker(...args), courseUrl);
});
diff --git a/src/widgets/ProductRecommendations/utils.js b/src/widgets/ProductRecommendations/utils.js
index e4074d3e..36b8b93c 100644
--- a/src/widgets/ProductRecommendations/utils.js
+++ b/src/widgets/ProductRecommendations/utils.js
@@ -1,4 +1,5 @@
import PropTypes from 'prop-types';
+import { executiveEducation, course, bootCamp } from './constants';
export const courseShape = {
uuid: PropTypes.string,
@@ -22,24 +23,24 @@ export const courseShape = {
};
export const courseTypeToProductTypeMap = {
- course: 'Course',
- 'verified-audit': 'Course',
- verified: 'Course',
- audit: 'Course',
- 'credit-verified-audit': 'Course',
- 'spoc-verified-audit': 'Course',
+ course,
+ 'verified-audit': course,
+ verified: course,
+ audit: course,
+ 'credit-verified-audit': course,
+ 'spoc-verified-audit': course,
professional: 'Professional Certificate',
- 'bootcamp-2u': 'Boot Camp',
- 'executive-education-2u': 'Executive Education',
- 'executive-education': 'Executive Education',
+ 'bootcamp-2u': bootCamp,
+ 'executive-education-2u': executiveEducation,
+ 'executive-education': executiveEducation,
masters: "Master's",
'masters-verified-audit': "Master's",
};
export const courseTypeToProductLineMap = {
- 'Executive Education': 'executive-education',
- 'Boot Camp': 'boot-camps',
- Course: 'open-courses',
+ [executiveEducation]: 'executive-education',
+ [bootCamp]: 'boot-camps',
+ [course]: 'open-courses',
};
export const convertCourseRunKeyToCourseKey = (courseRunKey) => {