Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read from normalized metadata content_price in course cards #447

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Sep 26, 2024

Updates price source to check the normalized metadata content_price. The normalized_metadata retrieves content price from fixed_price_usd, first_enrollable_paid_seat_price, and entitlements

Also introduces a standardized format for displaying prices via formatPrices

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (0f2ad73) to head (5a0a02a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ents/catalogSearchResults/CatalogSearchResults.jsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   77.86%   78.00%   +0.13%     
==========================================
  Files          43       43              
  Lines         899      891       -8     
  Branches      250      248       -2     
==========================================
- Hits          700      695       -5     
+ Misses        191      188       -3     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 force-pushed the hu/ent-9482 branch 3 times, most recently from fe79b4e to 0c7f60c Compare September 27, 2024 13:01
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with small nit.

__mocks__/react-instantsearch-dom.jsx Outdated Show resolved Hide resolved
@brobro10000 brobro10000 merged commit 627b03d into main Oct 3, 2024
7 checks passed
@brobro10000 brobro10000 deleted the hu/ent-9482 branch October 3, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants