fix: fixed leak issue when checkpoint will be undefined #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 170 170
Lines 3471 3471
Branches 904 906 +2
=======================================
Hits 3204 3204
Misses 246 246
Partials 21 21
☔ View full report in Codecov by Sentry. |
sundasnoreen12
requested review from
awais-ansari,
asadazam93,
AhtishamShahid and
muhammadadeeltajamul
AhtishamShahid
approved these changes
Aug 8, 2023
awais-ansari
approved these changes
Aug 8, 2023
snglth
pushed a commit
to Abstract-Tech/community-theme-discussions
that referenced
this pull request
Jan 9, 2024
Co-authored-by: SundasNoreen <sundas.noreen@arbisoft.com> Co-authored-by: Awais Ansari <79941147+awais-ansari@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-987
Description
Fixed memory leak issue due to infinite times call of useeffect after adding new tour type in the "AVAILABLE_DISCUSSION_TOURS" in internals because of undefined checkpoints for newly added notification tour type which is for frontend-component-header-edx instead of discussion MFE.
Post-merge Checklist