-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added maxLength and default tip for email subject #154
fix: Added maxLength and default tip for email subject #154
Conversation
Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@Inferato CI is failing, can you have a look. Also, I've invited you to the triage team so tests will run automatically going forward. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 46 46
Lines 683 683
Branches 132 132
=======================================
Hits 567 567
Misses 116 116 ☔ View full report in Codecov by Sentry. |
Would it be too much to ask for a screenshot with the error message showing? |
Yeah. I'll add it to the description. |
@arbrandes Screenshot was added. FYI |
Thank you! But I'd also like to see one with the error pop-up introduced in this PR. Can you attach one? |
@Inferato - flagging this for you! |
Hi @Inferato! Friendly reminder re: Adolfo's request above. Thanks! |
Sorry for the delays, Taras is no longer a member of RG. I will leave the status update comments on each PR's comments. |
@arbrandes I switched to Taras' branch and checked the behavior. His fix adds the form help text and limits the subject input to 128 chars Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
If the user puts more than 128 symbols in the email subject it causes an error.
Added length restriction and field tip.
Related PR: #154