Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added maxLength and default tip for email subject #154

Conversation

Inferato
Copy link
Contributor

@Inferato Inferato commented Oct 6, 2023

If the user puts more than 128 symbols in the email subject it causes an error.
изображение

Added length restriction and field tip.
Related PR: #154

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 6, 2023

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 6, 2023
@mphilbrick211 mphilbrick211 requested a review from a team October 6, 2023 13:49
@arbrandes arbrandes self-requested a review October 6, 2023 16:57
@mphilbrick211 mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 10, 2023
@mphilbrick211 mphilbrick211 removed the request for review from a team October 10, 2023 18:44
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 24, 2023
@e0d
Copy link

e0d commented Oct 25, 2023

@Inferato CI is failing, can you have a look. Also, I've invited you to the triage team so tests will run automatically going forward.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2de1299) 83.01% compared to head (276da02) 83.01%.
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          46       46           
  Lines         683      683           
  Branches      132      132           
=======================================
  Hits          567      567           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arbrandes
Copy link
Contributor

Would it be too much to ask for a screenshot with the error message showing?

@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 14, 2023
@Inferato
Copy link
Contributor Author

Inferato commented Nov 16, 2023

Would it be too much to ask for a screenshot with the error message showing?

Yeah. I'll add it to the description.

@Inferato
Copy link
Contributor Author

@arbrandes Screenshot was added. FYI

@arbrandes
Copy link
Contributor

Thank you! But I'd also like to see one with the error pop-up introduced in this PR. Can you attach one?

@mphilbrick211
Copy link

Thank you! But I'd also like to see one with the error pop-up introduced in this PR. Can you attach one?

@Inferato - flagging this for you!

@mphilbrick211
Copy link

Hi @Inferato! Friendly reminder re: Adolfo's request above. Thanks!

@mphilbrick211
Copy link

Hi @Inferato! Friendly reminder re: Adolfo's request above. Thanks!

@Inferato - just following up on this!

@dyudyunov
Copy link
Contributor

@arbrandes @mphilbrick211

Sorry for the delays, Taras is no longer a member of RG.
Currently, I'm gathering all the PRs he worked on. I will check their statuses and update them if necessary.

I will leave the status update comments on each PR's comments.

@dyudyunov
Copy link
Contributor

@arbrandes I switched to Taras' branch and checked the behavior.

His fix adds the form help text and limits the subject input to 128 chars
image

Notes:

  • the help text (Maximum 128 characters) is always displayed (since the page loading)
  • according to changes I was not able to send emails with subject length > 128 chars
  • I reproduced the issue without Taras' changes on Quince (500 error when there are more than 128 chars)

@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Feb 21, 2024
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arbrandes arbrandes merged commit 20f2125 into openedx:master Feb 27, 2024
7 checks passed
@openedx-webhooks
Copy link

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants