Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating flex group cards for People Management tab #1336

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Oct 15, 2024

Screen.Recording.2024-10-15.at.3.14.41.PM.mov
Screenshot 2024-10-12 at 2 25 33 PM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.69%. Comparing base (57c70ff) to head (cd66717).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...it-management/data/hooks/useAllEnterpriseGroups.js 28.57% 5 Missing ⚠️
src/data/services/LmsApiService.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1336      +/-   ##
==========================================
- Coverage   85.70%   85.69%   -0.01%     
==========================================
  Files         587      591       +4     
  Lines       12876    12920      +44     
  Branches     2723     2733      +10     
==========================================
+ Hits        11035    11072      +37     
- Misses       1781     1787       +6     
- Partials       60       61       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…terpriseGroupUuid.js

Co-authored-by: Marlon Keating <322346+marlonkeating@users.noreply.github.com>
@kiram15 kiram15 merged commit b69e59e into master Oct 16, 2024
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9489 branch October 16, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants