Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabale dropdowns while loading data on analyticsV2 #1331

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Oct 8, 2024

Description

  • I disable the startDate, endDate, Granularity, and Calculation dropdowns while loading aggregates data.
  • Added currentDate as a default date for Data Updated on

JIRA -> ENT-9590

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (25db621) to head (6c4d7ec).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1331   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files         578      578           
  Lines       12730    12730           
  Branches     2667     2711   +44     
=======================================
  Hits        10906    10906           
+ Misses       1764     1763    -1     
- Partials       60       61    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Work!

@jajjibhai008 jajjibhai008 merged commit fdacee1 into master Oct 9, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9590 branch October 9, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants