feat: Create group base detail page #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiram15
force-pushed
the
kiram15/ENT-9506
branch
from
b3e1ebb
to
3d3b03e
Compare
kiram15
commented
Oct 7, 2024
| title={budgetNameAndEdit} | ||
| subtitle={`${enterpriseGroup?.acceptedMembersCount} accepted members`} | ||
| /> | ||
| <Card.Section className="pt-1 x-small">Created on</Card.Section> |
There was a problem hiding this comment.
Need to add in created to the serializer, will add this value in with my next ticket
katrinan029
requested changes
Oct 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
- Coverage 85.71% 85.70% -0.02%
==========================================
Files 581 587 +6
Lines 12797 12876 +79
Branches 2710 2723 +13
==========================================
+ Hits 10969 11035 +66
- Misses 1767 1780 +13
Partials 61 61 ☔ View full report in Codecov by Sentry. |
katrinan029
reviewed
Oct 9, 2024
katrinan029
reviewed
Oct 9, 2024
katrinan029
reviewed
Oct 9, 2024
katrinan029
reviewed
Oct 9, 2024
kiram15
force-pushed
the
kiram15/ENT-9506
branch
from
61d9d90
to
4ec4d2a
Compare
katrinan029
reviewed
Oct 10, 2024
katrinan029
reviewed
Oct 10, 2024
kiram15
force-pushed
the
kiram15/ENT-9506
branch
from
f121bbf
to
7e6e923
Compare
…min-portal into kiram15/ENT-9506
kiram15
force-pushed
the
kiram15/ENT-9506
branch
from
7e6e923
to
7d4966d
Compare
katrinan029
reviewed
Oct 15, 2024
| id="people.management.delete.group.modal.body.2" | ||
| defaultMessage={ | ||
| 'By deleting this group you will no longer be able to track analytics associated' | ||
| + 'with this group and the group will be removed from your People Management page.' |
There was a problem hiding this comment.
minor change here to add a space in front of with or after associated so that it doesn't look like one word.
katrinan029
reviewed
Oct 15, 2024
| )} | ||
| subtitle={`${enterpriseGroup.acceptedMembersCount} accepted members`} | ||
| /> | ||
| <Card.Section className="pt-1 x-small">Created on</Card.Section> |
There was a problem hiding this comment.
can we add in the created date since that's being returned by the response now?
katrinan029
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates the card for the groups detail page. Includes functionality for editing the group name and deleting the group.
https://2u-internal.atlassian.net/browse/ENT-9506
Test plan
For all changes
Only if submitting a visual change