-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create group base detail page #1329
Conversation
b3e1ebb
to
3d3b03e
Compare
title={budgetNameAndEdit} | ||
subtitle={`${enterpriseGroup?.acceptedMembersCount} accepted members`} | ||
/> | ||
<Card.Section className="pt-1 x-small">Created on</Card.Section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add in created to the serializer, will add this value in with my next ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far! I have some feedback regarding handling errors
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
- Coverage 85.71% 85.70% -0.02%
==========================================
Files 581 587 +6
Lines 12797 12876 +79
Branches 2710 2723 +13
==========================================
+ Hits 10969 11035 +66
- Misses 1767 1780 +13
Partials 61 61 ☔ View full report in Codecov by Sentry. |
61d9d90
to
4ec4d2a
Compare
f121bbf
to
7e6e923
Compare
…min-portal into kiram15/ENT-9506
7e6e923
to
7d4966d
Compare
id="people.management.delete.group.modal.body.2" | ||
defaultMessage={ | ||
'By deleting this group you will no longer be able to track analytics associated' | ||
+ 'with this group and the group will be removed from your People Management page.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
)} | ||
subtitle={`${enterpriseGroup.acceptedMembersCount} accepted members`} | ||
/> | ||
<Card.Section className="pt-1 x-small">Created on</Card.Section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add in the created date since that's being returned by the response now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of minor changes but it's good to go once they get addressed!
Description
Creates the card for the groups detail page. Includes functionality for editing the group name and deleting the group.
https://2u-internal.atlassian.net/browse/ENT-9506
Test plan
For all changes
Only if submitting a visual change