Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate skills charts #1274

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

muhammad-ammar
Copy link
Contributor

@muhammad-ammar muhammad-ammar commented Aug 19, 2024

Description: Integrate skills tab charts with API
JIRA: https://2u-internal.atlassian.net/browse/ENT-9241

Skills Tab Charts Screenshot
image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@muhammad-ammar muhammad-ammar marked this pull request as draft August 19, 2024 13:02
@muhammad-ammar muhammad-ammar force-pushed the ammar/integrate-skills-charts branch 2 times, most recently from 063d9ea to 09932d4 Compare August 23, 2024 10:26
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (7388dfc) to head (95b149b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
+ Coverage   85.44%   85.48%   +0.03%     
==========================================
  Files         560      562       +2     
  Lines       12232    12260      +28     
  Branches     2589     2563      -26     
==========================================
+ Hits        10452    10480      +28     
- Misses       1721     1722       +1     
+ Partials       59       58       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhammad-ammar muhammad-ammar marked this pull request as ready for review August 23, 2024 14:04
@muhammad-ammar muhammad-ammar force-pushed the ammar/integrate-skills-charts branch 6 times, most recently from 9833ca8 to 85f9c4f Compare August 28, 2024 04:20
@muhammad-ammar muhammad-ammar merged commit dc806a9 into master Aug 28, 2024
7 checks passed
@muhammad-ammar muhammad-ammar deleted the ammar/integrate-skills-charts branch August 28, 2024 06:13
Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muhammad-ammar muhammad-ammar added the plotly-migration Work to migrate from Plotly DASH to PlotlyJS label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plotly-migration Work to migrate from Plotly DASH to PlotlyJS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants