-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate skills charts #1274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/AdvanceAnalyticsV2/data/hooks/useEnterpriseSkillsAnalytics.js
Outdated
Show resolved
Hide resolved
muhammad-ammar
commented
Aug 21, 2024
src/components/AdvanceAnalyticsV2/data/hooks/useEnterpriseSkillsAnalytics.js
Outdated
Show resolved
Hide resolved
src/components/AdvanceAnalyticsV2/data/hooks/useEnterpriseSkillsAnalytics.js
Outdated
Show resolved
Hide resolved
src/components/AdvanceAnalyticsV2/data/hooks/useEnterpriseSkillsAnalytics.js
Outdated
Show resolved
Hide resolved
muhammad-ammar
force-pushed
the
ammar/integrate-skills-charts
branch
2 times, most recently
from
August 23, 2024 10:26
063d9ea
to
09932d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
+ Coverage 85.44% 85.48% +0.03%
==========================================
Files 560 562 +2
Lines 12232 12260 +28
Branches 2589 2563 -26
==========================================
+ Hits 10452 10480 +28
- Misses 1721 1722 +1
+ Partials 59 58 -1 ☔ View full report in Codecov by Sentry. |
muhammad-ammar
force-pushed
the
ammar/integrate-skills-charts
branch
6 times, most recently
from
August 28, 2024 04:20
9833ca8
to
85f9c4f
Compare
muhammad-ammar
force-pushed
the
ammar/integrate-skills-charts
branch
from
August 28, 2024 05:25
85f9c4f
to
95b149b
Compare
saleem-latif
approved these changes
Aug 28, 2024
jajjibhai008
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
muhammad-ammar
added
the
plotly-migration
Work to migrate from Plotly DASH to PlotlyJS
label
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Integrate skills tab charts with API
JIRA: https://2u-internal.atlassian.net/browse/ENT-9241
Skills Tab Charts Screenshot
For all changes
Only if submitting a visual change