-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update enterprise-app view height #1258
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1258 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 541 545 +4
Lines 11933 11970 +37
Branches 2550 2562 +12
=======================================
+ Hits 10189 10221 +32
- Misses 1685 1690 +5
Partials 59 59 ☔ View full report in Codecov by Sentry. |
const [globalState, dispatch] = useReducer(globalReducer, initialState); | ||
const globalContext = useMemo(() => ({ | ||
...globalState, | ||
// Offsets by an additional 1 rem to avoid rendering the scrollbar unnecessarily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offset the viewheight by an additional 1rem to avoid the scrollbar rendering when the main content does not overflow.
Before 1rem offset:
https://github.com/openedx/frontend-app-admin-portal/assets/82611798/828bf096-1ae9-4df2-817b-21260ee40854
After 1rem offset:
https://github.com/openedx/frontend-app-admin-portal/assets/82611798/4d507e9d-3d19-4c8d-9aae-7f63d2bc954a
e96a377
to
b2c92d4
Compare
5ae8b07
to
19b6f7b
Compare
This reverts commit e74391e.
This reverts commit e74391e.
Prior to these changes, the view height of the main enterprise-app component would cause a UI bug where if the content was less then the height of the sidebar, the sidebar would 'clip' into the footer creating an unsightly experience for users.
We have updated the CSS to make the main contents
min-height
100% of the view height with an offset to take into account the header/footer heights. The offset should avoid the user having to unnecessarily scroll down to see the footer.Before:
After
For all changes
Only if submitting a visual change