fix: update enterprise-app view height #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1258 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 541 545 +4
Lines 11933 11970 +37
Branches 2550 2562 +12
=======================================
+ Hits 10189 10221 +32
- Misses 1685 1690 +5
Partials 59 59 ☔ View full report in Codecov by Sentry. |
brobro10000
commented
Jun 26, 2024
| const [globalState, dispatch] = useReducer(globalReducer, initialState); | ||
| const globalContext = useMemo(() => ({ | ||
| ...globalState, | ||
| // Offsets by an additional 1 rem to avoid rendering the scrollbar unnecessarily |
There was a problem hiding this comment.
Offset the viewheight by an additional 1rem to avoid the scrollbar rendering when the main content does not overflow.
Before 1rem offset:
https://github.com/openedx/frontend-app-admin-portal/assets/82611798/828bf096-1ae9-4df2-817b-21260ee40854
After 1rem offset:
https://github.com/openedx/frontend-app-admin-portal/assets/82611798/4d507e9d-3d19-4c8d-9aae-7f63d2bc954a
brobro10000
force-pushed
the
hu/ent-9089
branch
2 times, most recently
from
e96a377
to
b2c92d4
Compare
brobro10000
force-pushed
the
hu/ent-9089
branch
2 times, most recently
from
5ae8b07
to
19b6f7b
Compare
macdiesel
approved these changes
Jun 27, 2024
adamstankiewicz
added a commit
that referenced
this pull request
Jul 8, 2024
This reverts commit e74391e.
3 tasks
adamstankiewicz
added a commit
that referenced
this pull request
Jul 8, 2024
This reverts commit e74391e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these changes, the view height of the main enterprise-app component would cause a UI bug where if the content was less then the height of the sidebar, the sidebar would 'clip' into the footer creating an unsightly experience for users.
We have updated the CSS to make the main contents
min-height100% of the view height with an offset to take into account the header/footer heights. The offset should avoid the user having to unnecessarily scroll down to see the footer.Before:
After
For all changes
Only if submitting a visual change