Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update help center and hide groups content #1247

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Jun 3, 2024

https://2u-internal.atlassian.net/browse/ENT-9042

This ticket changes all the help center links from placeholders to the correct groups link and adds an additional check to make sure the org has a groups association before showing groups content.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (1bffae3) to head (f7a3fcb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1247   +/-   ##
=======================================
  Coverage   85.30%   85.31%           
=======================================
  Files         538      538           
  Lines       11830    11833    +3     
  Branches     2522     2519    -3     
=======================================
+ Hits        10092    10095    +3     
+ Misses       1680     1679    -1     
- Partials       58       59    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 requested a review from a team June 3, 2024 19:02
Copy link
Contributor

@katrinan029 katrinan029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on stage and lgtm!

@kiram15 kiram15 merged commit 9fef4a4 into master Jun 3, 2024
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9042 branch June 3, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants