Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-8762: Marked strings for the i18n of the first 2 tabs of admin portal settings page. #1244

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

saleem-latif
Copy link
Contributor

Jira Ticket: ENT-8762

Description:
This PR makes sure static strings on the first two tabs of the Settings page have been marked for translation.

  1. Configure Access
  2. Single Sign-On (SSO)

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.30%. Comparing base (84d81b2) to head (3498f52).

Files Patch % Lines
...omponents/settings/SettingsSSOTab/SsoErrorPage.jsx 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
+ Coverage   85.28%   85.30%   +0.02%     
==========================================
  Files         538      538              
  Lines       11796    11830      +34     
  Branches     2509     2522      +13     
==========================================
+ Hits        10060    10092      +32     
- Misses       1678     1679       +1     
- Partials       58       59       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saleem-latif saleem-latif merged commit 1bffae3 into master Jun 3, 2024
6 checks passed
@saleem-latif saleem-latif deleted the saleem-latif/ENT-8762 branch June 3, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants