Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extraneous comma in budget card #1237

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented May 23, 2024

Description

In the budget card, there is an extraneous comma after the 'Configure access' button that is removed.
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/boards/630?assignee=712020%3A008f4187-4536-4e5b-ae31-b8cd7792730c&selectedIssue=ENT-9012

#UI changes

before after
Screenshot 2024-05-23 at 3 44 13 PM Screenshot 2024-05-23 at 3 48 21 PM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (957a425) to head (f7d9e7a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1237   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files         538      538           
  Lines       11773    11773           
  Branches     2502     2502           
=======================================
  Hits        10038    10038           
+ Misses       1679     1678    -1     
- Partials       56       57    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 self-requested a review May 24, 2024 15:00
@katrinan029 katrinan029 merged commit 682bade into master May 24, 2024
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9012 branch May 24, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants