Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve spacing issue with budget cards #1235

Merged
merged 1 commit into from
May 23, 2024

Conversation

adamstankiewicz
Copy link
Member

Before

image

After

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@@ -143,7 +143,7 @@ const BaseSubBudgetCard = ({
title={<BackgroundFetchingWrapper>{budgetType}</BackgroundFetchingWrapper>}
subtitle={<BackgroundFetchingWrapper>{subtitle}</BackgroundFetchingWrapper>}
actions={showActions ? renderActions(budgetId) : undefined}
className={classNames('align-items-center', { 'mb-4.5': !hasBudgetAggregatesSection })}
className={classNames('align-items-center', { 'mb-4.5': !hasBudgetAggregatesSection() })}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style fix

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (eba39d7) to head (811e3ca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1235   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         537      537           
  Lines       11709    11709           
  Branches     2480     2478    -2     
=======================================
  Hits         9994     9994           
  Misses       1663     1663           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz merged commit e69159d into master May 23, 2024
6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/retired-bug-fix branch May 23, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants