Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark static strings for i18n on lcm budgets page #1222

Merged
merged 1 commit into from
May 20, 2024

Conversation

jajjibhai008
Copy link
Contributor

Description

JIRA -> ENT-8750

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.33%. Comparing base (54b25e3) to head (c361095).

Files Patch % Lines
...onents/learner-credit-management/SubBudgetCard.jsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
+ Coverage   85.30%   85.33%   +0.02%     
==========================================
  Files         537      537              
  Lines       11596    11626      +30     
  Branches     2430     2439       +9     
==========================================
+ Hits         9892     9921      +29     
  Misses       1655     1655              
- Partials       49       50       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jajjibhai008 jajjibhai008 merged commit ea27f5f into master May 20, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-8750 branch May 20, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants