Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list transactions from the admin-tx view #1094

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

iloveagent57
Copy link
Contributor

ENT-7999

This PR https://github.com/openedx/frontend-app-admin-portal/pull/1087/files#diff-89082fcf3fbc9b339141578405314256fc4f1ae0210dab880414add817619ef7 pulls from the learner view, not the admin view. So it tries to fetch only the transactions associated with the requesting user. We want the admin-portal to pull from the admin view.

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cc1b8d) 84.68% compared to head (b925a9b) 84.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1094   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files         476      476           
  Lines        9954     9954           
  Branches     2082     2082           
=======================================
  Hits         8430     8430           
  Misses       1483     1483           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iloveagent57 iloveagent57 merged commit bd8455b into master Nov 20, 2023
6 checks passed
@iloveagent57 iloveagent57 deleted the aed/list-admin-transactions branch November 20, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants