feat: display refunds in spent table when backed by transactions API #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
- Coverage 84.66% 84.60% -0.07%
==========================================
Files 475 475
Lines 9934 9924 -10
Branches 2070 2076 +6
==========================================
- Hits 8411 8396 -15
- Misses 1482 1486 +4
- Partials 41 42 +1 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
commented
Nov 15, 2023
| courseListPrice: PropTypes.number.isRequired, | ||
| enrollmentDate: PropTypes.string.isRequired, | ||
| courseProductLine: PropTypes.string.isRequired, |
There was a problem hiding this comment.
[inform] "Product" column is no longer included in this table.
adamstankiewicz
force-pushed
the
ags/ent-7644
branch
2 times, most recently
from
f1ca9c7
to
8786422
Compare
adamstankiewicz
force-pushed
the
ags/ent-7644
branch
from
8786422
to
70ad071
Compare
adamstankiewicz
force-pushed
the
ags/ent-7644
branch
from
70ad071
to
c532abe
Compare
pwnage101
requested changes
Nov 15, 2023
| @@ -83,7 +86,7 @@ const useOfferRedemptions = ( | |||
| } | |||
| let data; | |||
| let transformedTableResults; | |||
| if (budgetId && shouldFetchSubsidyTransactions) { | |||
| if (budgetId && isTopDownAssignmentEnabled) { | |||
There was a problem hiding this comment.
why not just this?
Suggested change
| if (budgetId && isTopDownAssignmentEnabled) { | |
| if (shouldFetchSubsidyTransactions) { |
| if (budgetId !== null) { | ||
| options.budgetId = budgetId; | ||
| options[isTopDownAssignmentEnabled ? 'subsidyAccessPolicyUuid' : 'budgetId'] = budgetId; |
There was a problem hiding this comment.
Should this key off shouldFetchSubsidyTransactions instead?
Suggested change
| options[isTopDownAssignmentEnabled ? 'subsidyAccessPolicyUuid' : 'budgetId'] = budgetId; | |
| options[shouldFetchSubsidyTransactions ? 'subsidyAccessPolicyUuid' : 'budgetId'] = budgetId; |
There was a problem hiding this comment.
It could; I will update.
pwnage101
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: ENT-7644 | Figma
Summary:
transactionsAPI via enterprise-subsidy.transactionsAPI.?search_allwhen viewing a enterprise offer backed by the analytics API (it was passing?searchas it was were communicating totransactionsAPI instead).useBudgetDetailActivityOverviewwas calling the analytics API for spent transactions whereas the "Spent" table was pulling from thetransactions(enterprise-subsidy) API. These should always rely on the same data source.-to indicate that balance was drawn down (as seen in Figma spec and consistent with "Assigned" table).For all changes
Only if submitting a visual change