Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable creating new SSO config while configuring prior config in progress #1084

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

marlonkeating
Copy link
Contributor

Jira Ticket

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f1c1ac) 84.26% compared to head (7af7ec2) 84.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1084   +/-   ##
=======================================
  Coverage   84.26%   84.26%           
=======================================
  Files         463      463           
  Lines        9664     9668    +4     
  Branches     2007     2009    +2     
=======================================
+ Hits         8143     8147    +4     
  Misses       1479     1479           
  Partials       42       42           
Files Coverage Δ
.../settings/SettingsSSOTab/NewExistingSSOConfigs.jsx 100.00% <100.00%> (ø)
src/components/settings/SettingsSSOTab/index.jsx 85.24% <100.00%> (+0.50%) ⬆️
src/components/settings/SettingsSSOTab/utils.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marlonkeating marlonkeating merged commit 179524d into master Nov 7, 2023
6 checks passed
@marlonkeating marlonkeating deleted the mkeating/ENT-7919 branch November 7, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants