-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rely on new error_reason
field to determine failed learner_state
reason
#1079
Conversation
learner_state
; remove erroneous console.logslearner_state
; remove erroneous console.log
statements
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 84.15% 84.19% +0.04%
==========================================
Files 458 463 +5
Lines 9581 9613 +32
Branches 1996 1996
==========================================
+ Hits 8063 8094 +31
- Misses 1476 1477 +1
Partials 42 42
☔ View full report in Codecov by Sentry. |
learner_state
; remove erroneous console.log
statementslearner_state
reason; remove erroneous console.log
statements
@@ -29,7 +29,6 @@ const EnterpriseAppRoutes = ({ | |||
enableContentHighlightsPage, | |||
}) => { | |||
const { canManageLearnerCredit } = useContext(EnterpriseSubsidiesContext); | |||
console.log('EnterpriseAppRoutes!!!'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[context] These erroneous console.log
statements slipped through in the previous PR that merged while debugging one of the review comments. Removing the console.log
statements in this PR.
|
||
if (isBadEmailError) { | ||
// Determine which failure chip to display based on the error reason. | ||
if (errorReason === 'email_error') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[inform] Added via openedx/enterprise-access#314
learner_state
reason; remove erroneous console.log
statementslearner_state
reason
learner_state
reasonerror_reason
field to determine failed learner_state
reason
<li> | ||
Learners will receive automated reminder emails every 10-15 days until the enrollment | ||
deadline is reached. | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related PR: openedx/enterprise-access#314
Removes some business logic in the frontend in favor of relying on data returned by the API explicitly. That is, when an Assignment is an
errored
state, the API now returns the most recenterror_reason
from the associated Actions such that the frontend doesn't have to iterate through the list of Actions itself.For all changes
Only if submitting a visual change