fix: rely on new error_reason field to determine failed learner_state reason
#1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
changed the title
learner_state; remove erroneous console.logslearner_state; remove erroneous console.log statements
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 84.15% 84.19% +0.04%
==========================================
Files 458 463 +5
Lines 9581 9613 +32
Branches 1996 1996
==========================================
+ Hits 8063 8094 +31
- Misses 1476 1477 +1
Partials 42 42
☔ View full report in Codecov by Sentry. |
adamstankiewicz
changed the title
learner_state; remove erroneous console.log statementslearner_state reason; remove erroneous console.log statements
adamstankiewicz
commented
Nov 1, 2023
| @@ -29,7 +29,6 @@ const EnterpriseAppRoutes = ({ | |||
| enableContentHighlightsPage, | |||
| }) => { | |||
| const { canManageLearnerCredit } = useContext(EnterpriseSubsidiesContext); | |||
| console.log('EnterpriseAppRoutes!!!'); | |||
There was a problem hiding this comment.
[context] These erroneous console.log statements slipped through in the previous PR that merged while debugging one of the review comments. Removing the console.log statements in this PR.
adamstankiewicz
commented
Nov 1, 2023
|
|
||
| if (isBadEmailError) { | ||
| // Determine which failure chip to display based on the error reason. | ||
| if (errorReason === 'email_error') { |
There was a problem hiding this comment.
[inform] Added via openedx/enterprise-access#314
adamstankiewicz
changed the title
learner_state reason; remove erroneous console.log statementslearner_state reason
adamstankiewicz
changed the title
learner_state reasonerror_reason field to determine failed learner_state reason
adamstankiewicz
commented
Nov 2, 2023
Comment on lines
-23
to
-26
| <li> | ||
| Learners will receive automated reminder emails every 10-15 days until the enrollment | ||
| deadline is reached. | ||
| </li> |
There was a problem hiding this comment.
Removed based on this recent Figma annotation:
iloveagent57
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: openedx/enterprise-access#314
Removes some business logic in the frontend in favor of relying on data returned by the API explicitly. That is, when an Assignment is an
erroredstate, the API now returns the most recenterror_reasonfrom the associated Actions such that the frontend doesn't have to iterate through the list of Actions itself.For all changes
Only if submitting a visual change