-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "Refresh" CTA to the "Assigned" table; remove "Product" column from "Spent" table #1077
Conversation
const getCourseProductLineText = (courseProductLine) => { | ||
let courseProductLineText = ''; | ||
courseProductLineText = courseProductLine === 'OCM' ? 'Open Courses' : courseProductLine; | ||
return courseProductLineText; | ||
}; | ||
|
||
const getCourseProductLineAbbreviation = (courseProductLine) => { | ||
let courseProductLineText = ''; | ||
courseProductLineText = courseProductLine === 'Open Courses Marketplace' ? 'OCM' : 'Executive Education'; | ||
return courseProductLineText; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer used.
Cell: ({ row }) => `-${formatPrice(row.original.contentQuantity / 100, { maximumFractionDigits: 0 })}`, | ||
accessor: 'amount', | ||
Cell: ({ row }) => `-${formatPrice(row.original.contentQuantity / 100)}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change. maximumFractionDigits: 0
is now the default in formatPrice
.
3698f24
to
ed43850
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1077 +/- ##
==========================================
+ Coverage 84.11% 84.14% +0.02%
==========================================
Files 454 455 +1
Lines 9562 9560 -2
Branches 1993 1992 -1
==========================================
+ Hits 8043 8044 +1
+ Misses 1476 1474 -2
+ Partials 43 42 -1
☔ View full report in Codecov by Sentry. |
Description
ENT-7902
refresh_assigned_table_demo.mov
For all changes
Only if submitting a visual change