feat: add "Refresh" CTA to the "Assigned" table; remove "Product" column from "Spent" table #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
changed the title
adamstankiewicz
commented
Oct 30, 2023
Comment on lines
-403
to
-413
| const getCourseProductLineText = (courseProductLine) => { | ||
| let courseProductLineText = ''; | ||
| courseProductLineText = courseProductLine === 'OCM' ? 'Open Courses' : courseProductLine; | ||
| return courseProductLineText; | ||
| }; | ||
|
|
||
| const getCourseProductLineAbbreviation = (courseProductLine) => { | ||
| let courseProductLineText = ''; | ||
| courseProductLineText = courseProductLine === 'Open Courses Marketplace' ? 'OCM' : 'Executive Education'; | ||
| return courseProductLineText; | ||
| }; |
adamstankiewicz
commented
Oct 30, 2023
Comment on lines
-38
to
+40
| Cell: ({ row }) => `-${formatPrice(row.original.contentQuantity / 100, { maximumFractionDigits: 0 })}`, | ||
| accessor: 'amount', | ||
| Cell: ({ row }) => `-${formatPrice(row.original.contentQuantity / 100)}`, |
There was a problem hiding this comment.
No change. maximumFractionDigits: 0 is now the default in formatPrice.
adamstankiewicz
force-pushed
the
ags/ent-7902
branch
from
3698f24
to
ed43850
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1077 +/- ##
==========================================
+ Coverage 84.11% 84.14% +0.02%
==========================================
Files 454 455 +1
Lines 9562 9560 -2
Branches 1993 1992 -1
==========================================
+ Hits 8043 8044 +1
+ Misses 1476 1474 -2
+ Partials 43 42 -1
☔ View full report in Codecov by Sentry. |
iloveagent57
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENT-7902
refresh_assigned_table_demo.mov
For all changes
Only if submitting a visual change