feat: add display name in heading of catalog tab #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinan029
changed the base branch from
knguyen2/ENT-7594
to
knguyen/ENT-7594
src/components/learner-credit-management/search/CatalogSearch.jsx
Outdated
Show resolved
Hide resolved
|
|
||
| return ( | ||
| <section> | ||
| <FormattedMessage | ||
| id="catalogs.enterpriseCatalogs.header" | ||
| defaultMessage="Budget associated catalog" | ||
| defaultMessage={subsidyAccessPolicy?.displayName || 'Overview'} |
There was a problem hiding this comment.
nit: could likely remove the ? from subsidyAccessPolicy?.displayName given we can assume the subsidyAccessPolicy exists if this component is rendered (similar to line 16 above).
src/components/learner-credit-management/search/CatalogSearch.jsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1074 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 454 454
Lines 9562 9563 +1
Branches 1993 1994 +1
=======================================
+ Hits 8043 8044 +1
Misses 1476 1476
Partials 43 43
☔ View full report in Codecov by Sentry. |
adamstankiewicz
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The “Catalog” tab needs to have an appropriate heading displayed in the tab’s contents.
JIRA Ticket
Solution
Render the
displayNamefrom the policydisplay_namefield.For all changes
Only if submitting a visual change