-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add display name in heading of catalog tab #1074
Conversation
src/components/learner-credit-management/search/CatalogSearch.jsx
Outdated
Show resolved
Hide resolved
|
||
return ( | ||
<section> | ||
<FormattedMessage | ||
id="catalogs.enterpriseCatalogs.header" | ||
defaultMessage="Budget associated catalog" | ||
defaultMessage={subsidyAccessPolicy?.displayName || 'Overview'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could likely remove the ?
from subsidyAccessPolicy?.displayName
given we can assume the subsidyAccessPolicy
exists if this component is rendered (similar to line 16 above).
src/components/learner-credit-management/search/CatalogSearch.jsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1074 +/- ##
=======================================
Coverage 84.11% 84.11%
=======================================
Files 454 454
Lines 9562 9563 +1
Branches 1993 1994 +1
=======================================
+ Hits 8043 8044 +1
Misses 1476 1476
Partials 43 43
☔ View full report in Codecov by Sentry. |
Description
The “Catalog” tab needs to have an appropriate heading displayed in the tab’s contents.
JIRA Ticket
Solution
Render the
displayName
from the policydisplay_name
field.For all changes
Only if submitting a visual change