feat: add course/program detail to 'View Course' button #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinan029
changed the title
katrinan029
changed the base branch from
knguyen/ENT-7591
to
knguyen2/ENT-7591
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1065 +/- ##
=======================================
Coverage 84.10% 84.11%
=======================================
Files 454 454
Lines 9557 9562 +5
Branches 1991 1993 +2
=======================================
+ Hits 8038 8043 +5
Misses 1476 1476
Partials 43 43
☔ View full report in Codecov by Sentry. |
marlonkeating
approved these changes
Oct 19, 2023
src/components/learner-credit-management/BudgetDetailCatalogTabContents.jsx
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/search/CatalogSearchResults.jsx
Outdated
Show resolved
Hide resolved
adamstankiewicz
approved these changes
Oct 30, 2023
|
@katrinan029 Changes look good to me! Just a heads up, looks like there is 1 failing test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The “Catalog” tab of the LCM budget detail page includes search results of the content contained by the catalog associated with the budget/policy currently being viewed. The search results only depict minimal information to the user such as the course image, partner, course title, price, and relevant dates. However, there is not enough information included for users to make informed decisions about which course to recommend.
Solution
Add a hyperlink to the 'View Course' button that links to the learner portal course about page in a new tab.
Screen.Recording.2023-10-19.at.2.47.30.PM.mov
For all changes
Only if submitting a visual change