-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search results cards #1041
Conversation
.btn-primary { | ||
background-color: ${brandColors.primary.regular.hex()} !important; | ||
border-color: ${brandColors.primary.regular.hex()} !important; | ||
color: ${brandColors.primary.textColor.hex()} !important; | ||
} | ||
.btn-primary:hover { | ||
background-color: ${brandColors.primary.dark.hex()} !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was overriding the styles for the buttons in SearchPagination
component. I removed this and it doesn't look like it affected other areas of the app.
[question] should we be using hooks to override styles and is this the best approach?
pageSize: 15, | ||
pageIndex: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] I'm setting the initial prop pageSize
to display 15 results per the figma mock, but the datatable displays 20. The same behavior happens when I set the prop pageSize
on line 98 to 15 as well. Why is this happening?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 83.20% 83.05% -0.15%
==========================================
Files 432 436 +4
Lines 9164 9219 +55
Branches 1875 1889 +14
==========================================
+ Hits 7625 7657 +32
- Misses 1497 1518 +21
- Partials 42 44 +2
☔ View full report in Codecov by Sentry. |
closing this PR due to merging conflicts. duplicate PR here #1059 |
Description
Display formatted search results on budget detail "Catalog" tab for top-down assignment based off the search filtering/search results from ticket https://2u-internal.atlassian.net/browse/ENT-7339.
Solution
Implement Paragon's Datatable and cards with the appropriate badges for exec ed and open courses.
Files to review for this PR:
src/components/learner-credit-management/search/CatalogSearchResults.jsx
src/components/learner-credit-management/cards/CourseCard.jsx
src/components/learner-credit-management/constants.js
src/components/settings/data/hooks.js
UI
For all changes
Only if submitting a visual change