fix: Bug bash fixes #1029
Merged
fix: Bug bash fixes #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
=======================================
Coverage 83.03% 83.03%
=======================================
Files 412 412
Lines 8857 8859 +2
Branches 1821 1821
=======================================
+ Hits 7354 7356 +2
Misses 1464 1464
Partials 39 39
☔ View full report in Codecov by Sentry. |
Comment on lines
+15
to
+16
| const newData = data; | ||
| ['user', 'id'].forEach(prop => delete newData[prop]); |
There was a problem hiding this comment.
Do we need to make a newData variable here? Because we're just making a reference copy, this statement is equivalent to deleting from the original data variable.
There was a problem hiding this comment.
We just had some eslint things about making direct changes to a parameter. Maybe the error isn't smart enough to catch something being pass by reference vs value but I still don't love to change passed in variables
marlonkeating
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/ENT-7682
For all changes
Only if submitting a visual change